On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao
wrote:
> When there's an APPLICATION_MODAL window, all other windows are disabled and
> re-enabled when the APPLICATION_MODAL window closes. This causes
> `requestToFront()` to be called on every window, and it does
On Tue, 10 May 2022 12:56:53 GMT, Thiago Milczarek Sayao
wrote:
>> When there's an APPLICATION_MODAL window, all other windows are disabled and
>> re-enabled when the APPLICATION_MODAL window closes. This causes
>> `requestToFront()` to be called on every window, an
ps://bugs.openjdk.java.net/browse/JDK-8269429
>
> But this one might need another fix:
> https://bugs.openjdk.java.net/browse/JDK-8240640
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Revert "Set the focus on
On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao
wrote:
> When there's an APPLICATION_MODAL window, all other windows are disabled and
> re-enabled when the APPLICATION_MODAL window closes. This causes
> `requestToFront()` to be called on every window, and it does
ps://bugs.openjdk.java.net/browse/JDK-8269429
>
> But this one might need another fix:
> https://bugs.openjdk.java.net/browse/JDK-8240640
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Set the focus on the
On Fri, 22 Apr 2022 19:26:36 GMT, Thiago Milczarek Sayao
wrote:
> When there's an APPLICATION_MODAL window, all other windows are disabled and
> re-enabled when the APPLICATION_MODAL window closes. This causes
> `requestToFront()` to be called on every window, and it does
On Thu, 5 May 2022 13:46:56 GMT, Ambarish Rapte wrote:
>> When there's an APPLICATION_MODAL window, all other windows are disabled and
>> re-enabled when the APPLICATION_MODAL window closes. This causes
>> `requestToFront()` to be called on every window, and it does not guarantee
>> order.
>>
When there's an APPLICATION_MODAL window, all other windows are disabled and
re-enabled when the APPLICATION_MODAL window closes. This causes
`requestToFront()` to be called on every window, and it does not guarantee
order.
The fix also works for:
https://bugs.openjdk.java.net/browse/JDK-826942
On Mon, 14 Mar 2022 18:18:38 GMT, Kevin Rushforth wrote:
>> doc-files/release-notes-18.md line 105:
>>
>>> 103: [JDK-8274929](https://bugs.openjdk.java.net/browse/JDK-8274929)|Crash
>>> while reading specific clipboard content|window-toolkit
>>> 104: [JDK-8275723](https://bugs.openjdk.java.net/
On Sun, 13 Mar 2022 10:07:26 GMT, Abhinay Agarwal wrote:
>> Add release notes for JavaFX 18 to the repository
>
> Abhinay Agarwal has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
> - s/Enhancement/Enhancements
> - C
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao
wrote:
> Found the problem thru this path:
>
> **WindowStage.java**
>
> final void handleFocusDisabled() {
> if (activeWindows.isEmpty()) {
> return;
> }
> WindowStage
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatible with ot
On Tue, 8 Mar 2022 13:12:03 GMT, Ambarish Rapte wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Capture event serial on process_key
>
> modules/javafx.graphics/src/main/nat
On Sat, 11 Dec 2021 00:32:06 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minimize changes
>
> On my Ubuntu 20.04 VM the bug still happens ab
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatib
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatible with o
On Mon, 1 Nov 2021 16:46:34 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
On Mon, 1 Nov 2021 16:46:34 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatible with other
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatible with other
On Fri, 29 Oct 2021 22:35:47 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatible with o
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatible with ot
On Tue, 12 Oct 2021 15:16:53 GMT, Pankaj Bansal wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java
>> line 861:
>>
>>> 859:
>>> 860: // walk backwards to find a blocker
>>> 861: for (int i = activeWindows.size() - 1; i > 0; i--) {
>>
>>
On Mon, 16 Aug 2021 06:23:01 GMT, Pankaj Bansal wrote:
>> Weird, It works consistently for me on 20.04. Just tested again to be sure.
>
>> Weird, It works consistently for me on 20.04. Just tested again to be sure.
>
> I am running a 20.04 VM. The test fails for me 60-70% of the time. I will
>
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao
wrote:
>> Found the problem thru this path:
>>
>> **WindowStage.java**
>>
>> final void handleFocusDisabled() {
>> if (activeWindows.isEmpty()) {
>> return;
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatible with oth
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao
wrote:
> Found the problem thru this path:
>
> **WindowStage.java**
>
> final void handleFocusDisabled() {
> if (activeWindows.isEmpty()) {
> return;
> }
> WindowStage
side looks ok, java side on `handleFocusDisabled` I did
> not understand why it `requestToFront` and `requestFocus` on the latest
> window.
>
> The solution makes disabled windows unfocusable and prevents mouse and
> keyboard events as the docs states, making it compatible
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao
wrote:
> Found the problem thru this path:
>
> **WindowStage.java**
>
> final void handleFocusDisabled() {
> if (activeWindows.isEmpty()) {
> return;
> }
> WindowStage
On Fri, 6 Aug 2021 02:18:38 GMT, Thiago Milczarek Sayao
wrote:
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> I have simplified the gtk2 `DragView::View::
-cp
> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
- Fix leak
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/599/files
- new: https:
On Thu, 16 Sep 2021 21:57:08 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review requests.
>
> modules/javafx.graphics/src/main/native-glass/gtk/gla
On Mon, 16 Aug 2021 06:23:01 GMT, Pankaj Bansal wrote:
>> Weird, It works consistently for me on 20.04. Just tested again to be sure.
>
>> Weird, It works consistently for me on 20.04. Just tested again to be sure.
>
> I am running a 20.04 VM. The test fails for me 60-70% of the time. I will
>
On Tue, 17 Aug 2021 13:10:53 GMT, Pankaj Bansal wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change test to manual
>
> tests/manual/dnd/DndTestDragViewR
-cp
> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Review requests.
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/599/files
- ne
On Sun, 15 Aug 2021 21:18:51 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2
-cp
> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Change test to manual
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/599/files
- ne
On Wed, 11 Aug 2021 23:42:47 GMT, Thiago Milczarek Sayao
wrote:
>> It seems raw images need to be converted BRGA -> RGBA.
>>
>> It was being converted on gtk2 code path, but gtk3 only uses
>> `gtk_drag_set_icon_pixbuf`.
>>
>> I have simplified the gtk2
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao
wrote:
> Found the problem thru this path:
>
> **WindowStage.java**
>
> final void handleFocusDisabled() {
> if (activeWindows.isEmpty()) {
> return;
> }
> WindowStage
On Sun, 15 Aug 2021 16:26:59 GMT, Pankaj Bansal wrote:
>> Test works on Linux, don't know on other platforms.
>>
>> `gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
>> test.robot.javafx.dnd.DndRawImageTest`
>
>> Test works on Linux, don't know on other platforms.
>>
>> `gra
-cp
> apps/toys/DragDrop/dist/DragDrop.jar dragdrop.DragDropColor
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Provide test
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/599/files
- new: https:
On Fri, 6 Aug 2021 02:18:38 GMT, Thiago Milczarek Sayao
wrote:
> It seems raw images need to be converted BRGA -> RGBA.
>
> It was being converted on gtk2 code path, but gtk3 only uses
> `gtk_drag_set_icon_pixbuf`.
>
> I have simplified the gtk2 `DragView::View::
On Fri, 6 Aug 2021 05:30:39 GMT, Pankaj Bansal wrote:
> I will look at this. Meanwhile, could you please write an automated system
> test for this?
Sure, I would provide it, but in the past drag and drop tests were not
possible. Any ideas?
-
PR: https://git.openjdk.java.net/jfx/p
It seems raw images need to be converted BRGA -> RGBA.
It was being converted on gtk2 code path, but gtk3 only uses
`gtk_drag_set_icon_pixbuf`.
It simplified the gtk2 `DragView::View::expose` to paint with
`gdk_cairo_set_source_pixbuf` (that is available since Gtk 2.8). The existing
path seem
On Thu, 5 Aug 2021 23:38:06 GMT, Thiago Milczarek Sayao
wrote:
> Found the problem thru this path:
>
> **WindowStage.java**
>
> final void handleFocusDisabled() {
> if (activeWindows.isEmpty()) {
> return;
> }
> WindowStage
Found the problem thru this path:
**WindowStage.java**
final void handleFocusDisabled() {
if (activeWindows.isEmpty()) {
return;
}
WindowStage window = activeWindows.get(activeWindows.size() - 1);
window.setIconified(false);
window.requestTo
On Mon, 28 Jun 2021 16:56:44 GMT, Thiago Milczarek Sayao
wrote:
> The PR approach is to set `gtk_window_set_keep_above` to true on
> APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL
> windows.
>
> This is passed on WindowStage.java:198 as a mask.
On Sat, 10 Jul 2021 16:06:18 GMT, Thiago Milczarek Sayao
wrote:
>> The PR approach is to set `gtk_window_set_keep_above` to true on
>> APPLICATION_MODAL windows, so they will not stay behind non
>> APPLICATION_MODAL windows.
>>
>> This is passed on WindowStage.
On Fri, 9 Jul 2021 18:41:11 GMT, Kevin Rushforth wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Reuse existing set_modal (which was previously unused).
>
> modules/javafx.
This seems the right
> function to be called for `APPLICATION_MODAL`, as `_enterModalWithWindow`
> fits for `WINDOW_MODAL`.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Remove unneeded test for modal
---
On Tue, 29 Jun 2021 21:58:36 GMT, Thiago Milczarek Sayao
wrote:
>> The PR approach is to set `gtk_window_set_keep_above` to true on
>> APPLICATION_MODAL windows, so they will not stay behind non
>> APPLICATION_MODAL windows.
>>
>> This is passed on WindowStage.
On Tue, 29 Jun 2021 21:58:36 GMT, Thiago Milczarek Sayao
wrote:
>> The PR approach is to set `gtk_window_set_keep_above` to true on
>> APPLICATION_MODAL windows, so they will not stay behind non
>> APPLICATION_MODAL windows.
>>
>> This is passed on WindowStage.
On Tue, 29 Jun 2021 21:05:06 GMT, Kevin Rushforth wrote:
> I tried the test program attached to the JBS bug, and I'm not seeing the
> problem. Are there any special steps I need to take to see the bug? I also
> left a question about `WINDOW_MODAL` vs `APPLICATION_MODAL` windows.
>
> Regarding
This seems the right
> function to be called for `APPLICATION_MODAL`, as `_enterModalWithWindow`
> fits for `WINDOW_MODAL`.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Reuse existing set_modal (
On Mon, 28 Jun 2021 16:56:44 GMT, Thiago Milczarek Sayao
wrote:
> The PR approach is to set `gtk_window_set_keep_above` to true on
> APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL
> windows.
>
> This is passed on WindowStage.java:198 as a mask.
The PR approach is to set `gtk_window_set_keep_above` to true on
APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL
windows.
This is passed on WindowStage.java:198 as a mask.
The weird thing is that `_enterModal()` is never called. This seems the right
function to b
On Mon, 28 Jun 2021 16:56:44 GMT, Thiago Milczarek Sayao
wrote:
> The PR approach is to set `gtk_window_set_keep_above` to true on
> APPLICATION_MODAL windows, so they will not stay behind non APPLICATION_MODAL
> windows.
>
> This is passed on WindowStage.java:198 as a mask.
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix build
gtk_widget_se
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request with a new target base due
to a merge or a rebase. The pull request now contains 20 co
On Mon, 5 Apr 2021 22:25:55 GMT, Kevin Rushforth wrote:
>> This PR filters out `GDK_TOUCH_EVENT_MASK` from `GDK_ALL_EVENTS_MASK` to
>> prevent touch events from being used instead of regular mouse events on
>> Linux platforms. Note that the touch events will be delivered as mouse
>> pressed/dr
On Sat, 6 Mar 2021 23:53:06 GMT, Thiago Milczarek Sayao
wrote:
>> Changed to WIP while we run some more tests to make sure latest changes are
>> ok.
>> I'm fixing some residual "extra resize" issues (these issues exists on the
>> current versi
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix bug in conte
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Small compila
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request with a new target base due
to a merge or a rebase. The pull request now contains 15 commits:
- Re
On Wed, 3 Mar 2021 12:14:47 GMT, Thiago Milczarek Sayao
wrote:
>> Changed to WIP to reduce sizing events.
>
> Changed to WIP while we run some more tests to make sure latest changes are
> ok.
> I'm fixing some residual "extra resize" issues (these issues exis
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
One more small issue
-
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
It's probably good now
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
It's looking good. E
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Adjust positioning (not 100% ye
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Partial progress
-
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
More test fixes
-
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix more te
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Small change to reuse get
On Thu, 18 Feb 2021 21:24:31 GMT, Thiago Milczarek Sayao
wrote:
>> Current Status:
>>
>> 
>
> Ready to be reviewed.
Changed to WIP while we run some more t
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Hopefully fix all "extra r
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Default to 320x2
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has refreshed the contents of this pull request, and
previous commits have been removed. The incremental views will show differen
On Thu, 18 Feb 2021 21:14:44 GMT, Thiago Milczarek Sayao
wrote:
>> Changed to WIP to reduce sizing events.
>
> Current Status:
>
> 
Ready to be reviewed.
--
On Sun, 14 Feb 2021 22:06:34 GMT, Thiago Milczarek Sayao
wrote:
>> It's been pointed out about this
>> https://stackoverflow.com/questions/49512491/javafx-getting-single-resize-events
>>
>> My tests point out that this PR causes less sizing events that the current
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix center
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Turns out gravity is used!
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Pass PixelBufferDrawTest
-
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix maximize bug
-
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Another approach to avoid
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fixes
-
Changes:
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Prefer bool
-
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request with a new target base due
to a merge or a rebase. The incremental webrev excludes the unrelated c
On Wed, 27 Jan 2021 16:39:55 GMT, Thiago Milczarek Sayao
wrote:
>> This does look like a much more manageable approach.
>>
>> One thing to be aware of from a bookkeeping point of view is that a JBS
>> issues is resolved by a single PR. Once a PR has been integrated fo
On Tue, 26 Jan 2021 00:01:44 GMT, Kevin Rushforth wrote:
>> This is a new approach to rewrite parts of gtk glass backend to be more
>> clean.
>>
>> I will provide small "manageable" PR to incrementally make the backend
>> better.
>>
>> This PR adresses cleanup of the Size and Positioning code
On Mon, 6 Jan 2020 00:28:14 GMT, Thiago Milczarek Sayao
wrote:
> ### Summary
> * Simplify and update the Gtk glass backend, making Linux a first-class
> OpenJFX platform.
>
> ### Goals
> * Make Linux a first-class OpenJFX platform (see Motivation);
> * Simplify the code
On Mon, 25 Jan 2021 23:49:38 GMT, Kevin Rushforth wrote:
>> I would prefer this approach:
>> https://github.com/openjdk/jfx/pull/367
>
> Given the alternate approach that you propose to pursue (which I agree is a
> better option), this PR should either be closed or moved to Draft.
Closing it in
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Revert change to reduce si
-PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.stage.IconifyTest` on a second run produces 4 tests, 2
> failures.
Thiago Milczarek Sayao has updated the pull request with a new target base due
to a merge or a rebase. The incremental webrev excludes the unrelated c
On Tue, 22 Sep 2020 01:12:44 GMT, Thiago Milczarek Sayao
wrote:
>> Rebased onto "master" and squashed commits.
>
> Tested on Ubuntu 20.04
>
> 756 tests completed, 6 failed, 110 skipped
>
> Failed:
> test.robot.javafx.scene.ColorPickerTes
On Mon, 21 Sep 2020 23:40:50 GMT, Thiago Milczarek Sayao
wrote:
>>> I would starting hooking gtk event signals
>>> (https://developer.gnome.org/gtk3/stable/GtkWidget.html), specially the
>>> "touch-event" to JavaFx events (probably need to add through JN
On Wed, 29 Jul 2020 21:01:42 GMT, Tor (torbuntu)
wrote:
>> @Torbuntu Not to this PR, I don't want to delay it too much. But can be done
>> (I just do not own a touch device currently).
>
> Sounds good! I have a few devices I'd be more than excited to test on, and
> even help add the feature my
On Fri, 12 Jun 2020 13:51:58 GMT, Kevin Rushforth wrote:
>>> After the latest commit on June 10, this is not building for me on my
>>> Ubuntu 18.04. I am attaching the build log for reference.
>>> [build.log](https://github.com/openjdk/jfx/files/4770864/build.log)
>>
>> It's now fixed. I had us
On Tue, 9 Jun 2020 23:14:31 GMT, Kevin Rushforth wrote:
> I am running a full test using GTK 3 on Ubuntu 20.04 and will publish
> results. I will later do the same for Oracle Linux 7.7.
>
> One thing to note is that this new GTK pipeline doesn't run on Ubuntu 16.04.
> I get the following runni
On Sun, 14 Jun 2020 11:55:45 GMT, Pankaj Bansal wrote:
>> Following are results in Ubuntu 18.04 after fix for tab pane tests.
>> > src="https://user-images.githubusercontent.com/6153953/84587007-3abc2880-ae39-11ea-8b61-0cbb86e4d4b5.png";>
>
> This is the result on OL 82 with latest commit
> src=
1 - 100 of 286 matches
Mail list logo
