Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications

2020-03-13 Thread Tobias Diez
On Thu, 7 Nov 2019 10:26:12 GMT, Kevin Rushforth wrote: >> Hi Tobias, >> A PR needs to refer a bug in JBS. (see >> https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md) >> Do you have an account in JBS? If not, I can file one for you. > > @tobiasdiez are you still interested in pursuing th

RFR: 8240969: WebView does not allow to load style sheet in modularized applications

2020-03-13 Thread Tobias Diez
Currently, loading a style sheet file using `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url start's with `jrt`, i.e. if the file is packaged in an application image using jlink. This is fixed with this PR. - Commit messages: - WebView: Allow to load style shee

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications

2020-03-13 Thread Tobias Diez
On Thu, 7 Nov 2019 12:11:39 GMT, Tobias Diez wrote: >> @tobiasdiez are you still interested in pursuing this fix? > > Yes, I am. But, to be honest, it's a bit overly complicated to contribute > here with the JBS bug requirement and the > oracle agreement. Hopefully I

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications

2020-03-13 Thread Tobias Diez
On Tue, 25 Feb 2020 16:14:05 GMT, HGuillemet wrote: >> @tobiasdiez in case you missed the earlier comment, this is now ready for >> you to proceed. All we need is a bug report >> with a test case. You can file the bug at >> [bugreport.java.com](https://bugreport.java.com/). > > Has this bug be

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications

2020-03-13 Thread Tobias Diez
On Thu, 12 Mar 2020 21:31:22 GMT, Kevin Rushforth wrote: >> Sorry for the delay, but I've finally managed to create the required bug >> report (internal review ID : 9063979) > > This has now been transferred to the JDK project as > [JDK-8240969](https://bugs.openjdk.java.net/browse/JDK-8240969)

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications

2020-03-13 Thread Tobias Diez
On Fri, 13 Mar 2020 12:55:27 GMT, Kevin Rushforth wrote: >> I've changed the title accordingly. However, I've no idea how to add a test >> and couldn't find any unit test concerning >> `UserStyleSheetLocation` (apart from some tests that make sure it was >> invoked on the Javafx thread). > > Yo

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications

2020-04-14 Thread Tobias Diez
On Tue, 14 Apr 2020 11:49:50 GMT, Kevin Rushforth wrote: >> Yes, we had this exception in our application which was (temporarily) fixed >> with >> https://github.com/JabRef/jabref/pull/5497. But JabRef is 100k lines of >> code, so I doubt this counts as a unit test. > > @tobiasdiez are you plan

Re: [Rev 01] RFR: 8240969: WebView does not allow to load style sheet in modularized applications

2020-04-14 Thread Tobias Diez
> Currently, loading a style sheet file using > `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url > start's with `jrt`, i.e. if the file is packaged in an application image > using jlink. This is fixed with this PR. Tobias Diez has updated the pull request i

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications [v3]

2020-08-02 Thread Tobias Diez
> Currently, loading a style sheet file using > `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url > start's with `jrt`, i.e. if the file is packaged in an application image > using jlink. This is fixed with this PR. Tobias Diez has updated the pull request i

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications [v3]

2020-08-13 Thread Tobias Diez
On Thu, 13 Aug 2020 21:36:52 GMT, Kevin Rushforth wrote: >> Tobias Diez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove whitespace > > modules/javafx.web/src/test/java/test/javafx/scene/web/Misc

Re: RFR: 8240969: WebView does not allow to load style sheet in modularized applications [v4]

2020-08-13 Thread Tobias Diez
> Currently, loading a style sheet file using > `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url > start's with `jrt`, i.e. if the file is packaged in an application image > using jlink. This is fixed with this PR. Tobias Diez has updated the pull request i

Integrated: 8240969: WebView does not allow to load style sheet in modularized applications

2020-08-14 Thread Tobias Diez
On Thu, 24 Oct 2019 16:42:14 GMT, Tobias Diez wrote: > Currently, loading a style sheet file using > `WebView.getEngine().setUserStyleSheetLocation(url)` fails if the url > start's with `jrt`, i.e. if the file is packaged in an application image > using jlink. This is f

Make TransformationList (Filtered and Sorted) extendable

2020-08-16 Thread Tobias Diez
Hello everybody, Right now it is hard to extend the FilteredList and the SortedList as these classes are marked final. This makes it practically impossible to add convenient helper methods, or change or extend the behavior of these classes. I agree that normally you don't need to extend them, but