Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-25 Thread Tomator
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Tue, 17 May 2022 13:34:47 GMT, yosbits wrote: > Reading the author's description of this PR, one wonders why the added > condition is not "glyphCode < 0". > > ```java > if (glyphCode <= 0) {return null;} > ``` Your suggestion is right - PR: https://git.openjdk.java.net/jfx/pul

RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
When I used BlueJ, I found a problem with Chinese display. /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode may return a negative number when no font library is specified in Linux,and this could cause java.lang.ArrayIndexOutOfBoundsException error.So javafx.graphics/c

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Mon, 16 May 2022 08:12:54 GMT, Tomator wrote: >> When I used BlueJ, I found a problem with Chinese display. >> /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode >> may return a negative number when no font library is specified in Linux,and &

Re: RFR: 8286867: Update #getGlyphCode return a negative number

2022-05-18 Thread Tomator
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this