Re: RFR: 8088420: JavaFX WebView memory leak via EventListener [v6]

2022-05-26 Thread danielpeintner
On Thu, 26 May 2022 07:08:59 GMT, Jay Bhaskar wrote: >> This PR is new implementation of JavaEvent listener memory management. >> Issue >> [JDK-8088420](https://bugs.openjdk.java.net/browse/JDK-8088420?filter=-1) >> >> 1. Calling remove event listener does not free jni global references. >> 2.

Re: RFR: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-02-16 Thread danielpeintner
On Wed, 16 Feb 2022 08:07:35 GMT, Ambarish Rapte wrote: > Include additional stabilization fixes of WebKit 613.1 > Sanity testing did not show any concerns. modules/javafx.web/src/main/native/Source/JavaScriptCore/API/JSRetainPtr.h line 9: > 7: * > 8: * 1. Redistributions of source code mus

Re: RFR: 8278595: Provide more information when a pipeline can't be used

2021-12-13 Thread danielpeintner
On Mon, 13 Dec 2021 11:00:02 GMT, Johan Vos wrote: > This PR provides at least some basic information when a pipeline can't be > used. > There are a number of reasons why a candidate pipeline can't be used, and > this PR makes it clear at which point the pipeline fails. > > The changes are o

Re: RFR: 8211294: [windows] TextArea content is blurry with 125% scaling

2020-09-25 Thread danielpeintner
On Fri, 25 Sep 2020 07:47:41 GMT, Johan Vos wrote: >> Also, I don't really have an idea on how this could be tested other than >> visually, so I'm open to suggestions. > > The visual representation corresponds with digits, so there can be tests that > check if the numbers are what we expect > t

Re: RFR: 8244824: TableView : Incorrect German translation

2020-05-15 Thread danielpeintner
On Fri, 15 May 2020 06:49:04 GMT, Ajit Ghaisas wrote: > Issue : https://bugs.openjdk.java.net/browse/JDK-8244824 > > Fix : As simple as it gets !!! FYI: While I agree "Inhalt" is better than "Content" the latter is not completely wrong (see https://www.duden.de/rechtschreibung/Content) --