On Wed, 30 Mar 2022 13:27:40 GMT, Johan Vos wrote:
>> When the size of a ListCell is changed and a scrollTo method is invoked
>> without having a layout calculation in between, the old (wrong) size is used
>> to calculcate the total estimate. This happens e.g. when the size is changed
>> in
On Thu, 17 Feb 2022 12:57:27 GMT, eduardsdv wrote:
> If the InputMethod's node is not in the scene, the default text location
> point is returned.
This pull request has now been integrated.
Changeset: a0bb545b
Author:Eduard Sedov
Committer: Ajit Ghaisas
URL:
On Mon, 21 Feb 2022 11:30:17 GMT, Ajit Ghaisas wrote:
>> eduardsdv has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>>8281953: Format TextInputControlSkinTest
>
> modules/javafx.controls/src/test/java/
> If the InputMethod's node is not in the scene, the default text location
> point is returned.
eduardsdv has updated the pull request incrementally with one additional commit
since the last revision:
8281953: Format TextInputControlSkinTest
-
Changes:
- all:
On Sat, 19 Feb 2022 17:40:54 GMT, delvh wrote:
>> If the InputMethod's node is not in the scene, the default text location
>> point is returned.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TextInputControlSkin.java
> line 340:
>
>> 338: if (window ==
If the InputMethod's node is not in the scene, the default text location point
is returned.
-
Commit messages:
- 8281953: NullPointer in InputMethod components in JFXPanel
Changes: https://git.openjdk.java.net/jfx/pull/735/files
Webrev:
On Tue, 11 Jan 2022 14:42:19 GMT, eduardsdv wrote:
> The NPE occurs when the skinnable is removed from the scene while the popup
> is showing.
> The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics
> from the scene and runs into NPE.
> To avoid NPE a null
; Since the mnemonics cannot be removed from the scene in standard way, when
> popup becomes hidden.
> They are now also removed from the scene, when the skinnable is removed from
> it.
eduardsdv has updated the pull request incrementally with one additional commit
since the last rev
On Tue, 11 Jan 2022 14:42:19 GMT, eduardsdv wrote:
> The NPE occurs when the skinnable is removed from the scene while the popup
> is showing.
> The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics
> from the scene and runs into NPE.
> To avoid NPE a null
The NPE occurs when the skinnable is removed from the scene while the popup is
showing.
The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics
from the scene and runs into NPE.
To avoid NPE a null-check is added to the 'showing' listener.
Since the mnemonics cannot be
On Wed, 22 Dec 2021 08:59:53 GMT, eduardsdv wrote:
> The NullPointer occurs when `Accessible.getAttribute(Object)` returns null.
> I checked all places where the `getAttribute(..)` method is called.
> Everywhere it is checked for null `(Accessible,` `MacAccessible,`
> `W
The NullPointer occurs when `Accessible.getAttribute(Object)` returns null.
I checked all places where the `getAttribute(..)` method is called. Everywhere
it is checked for null `(Accessible,` `MacAccessible,` `WinAccessible,`
`WinTextRangeProvider`). Only at this one place in
On Fri, 29 Oct 2021 12:19:40 GMT, eduardsdv wrote:
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
> element but to the bottom of the last element.
This pull request has now been integrated.
Changeset: 11583392
Author:Eduard Sedov
Committer: Johan Vo
On Mon, 6 Dec 2021 14:58:52 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit si
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
> element but to the bottom of the last element.
eduardsdv has updated the pull request incrementally with one additional commit
since the last revision:
8276167: Avoid additional Toolkit.getToolkit().fir
On Fri, 10 Dec 2021 15:00:56 GMT, Johan Vos wrote:
>> Without this line the test fails in the line 1865 with the message
>> 'expected:<7> but was:<8>'.
>> I think this is because in the line 1850 'listView.scrollTo(99)' is
>> executed, which now does not set the position to 1.
>>
>> It can
On Fri, 10 Dec 2021 12:33:29 GMT, Johan Vos wrote:
>> eduardsdv has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8276170: Add junit for VirtualFlow.scrollToTop(int)
>
> modules/javafx.controls/src/test/
On Fri, 10 Dec 2021 12:33:19 GMT, Johan Vos wrote:
>> eduardsdv has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8276170: Add junit for VirtualFlow.scrollToTop(int)
>
> modules/javafx.controls/src/main/
On Mon, 6 Dec 2021 14:58:52 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit si
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
> element but to the bottom of the last element.
eduardsdv has updated the pull request incrementally with one additional commit
since the last revision:
8276170: Add junit for VirtualFlow.scrollToT
On Mon, 6 Dec 2021 08:22:37 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request with a new target base due to a merge
> or a rebase. T
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
> element but to the bottom of the last element.
eduardsdv has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the
Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last element
but to the bottom of the last element.
-
Commit messages:
- JDK-8276167: fixing VirtualFlow.scrollToTop(int)
Changes: https://git.openjdk.java.net/jfx/pull/656/files
Webrev:
Create sources.jars and attach they to the publish task, so that they can be
uploaded to the (e.g. maven) repository automatically.
-
Commit messages:
- 8276170: Remove trailing whitespaces
- JDK-8276170: Create Sources when publishing to Maven
Changes:
24 matches
Mail list logo
