Re: [11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

2018-03-19 Thread Kevin Rushforth
This looks good to me, too, with one comment: The three new files have DOS line endings. Please convert to UNIX-style line endings, else it will fail jcheck (and fail the tools/scripts/checkWhiteSpace). -- Kevin mandy chung wrote: On 3/19/18 7:10 AM, Ambarish Rapte wrote: Hi Kevin,

Re: [11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

2018-03-19 Thread mandy chung
On 3/19/18 7:10 AM, Ambarish Rapte wrote: Hi Kevin, Alan & Mandy,     Request you to review this fix:     Webrev: http://cr.openjdk.java.net/~arapte/fx/8195800/webrev.00/     JBS:

[11] RFR : JDK-8195800 : Eliminate dependency on sun.reflect.misc in javafx modules

2018-03-19 Thread Ambarish Rapte
Hi Kevin, Alan & Mandy, Request you to review this fix: Webrev: http://cr.openjdk.java.net/~arapte/fx/8195800/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8195800 Regards, Ambarish