+1 with the additional refactoring done.
Regards
Prasanta
On 25-Sep-18 6:03 PM, Kevin Rushforth wrote:
Yes, that seems like a good bit of additional cleanup. I'll do that.
-- Kevin
On 9/25/2018 1:41 AM, Prasanta Sadhukhan wrote:
Hi Kevin,
Removal looks ok but one thing, do we still need to
Yes, that seems like a good bit of additional cleanup. I'll do that.
-- Kevin
On 9/25/2018 1:41 AM, Prasanta Sadhukhan wrote:
Hi Kevin,
Removal looks ok but one thing, do we still need to keep the
enhanced-for loop in InterOpFactory.java#getInstance now that we have
only 1 factory? I guess
Hi Kevin,
Removal looks ok but one thing, do we still need to keep the
enhanced-for loop in InterOpFactory.java#getInstance now that we have
only 1 factory? I guess we can probably remove the whole reflection
thing also and instantiate InteropFactoryN directly, no?
Regards
Prasanta
On 22-Sep
On 22/09/2018 00:53, Kevin Rushforth wrote:
Please review the following on GitHub:
https://bugs.openjdk.java.net/browse/JDK-8210092
https://github.com/javafxports/openjdk-jfx/pull/207
https://github.com/javafxports/openjdk-jfx/pull/207/files
This will remove the old JDK-10-based implementati
Please review the following on GitHub:
https://bugs.openjdk.java.net/browse/JDK-8210092
https://github.com/javafxports/openjdk-jfx/pull/207
https://github.com/javafxports/openjdk-jfx/pull/207/files
This will remove the old JDK-10-based implementation of FX / Swing
interop and cleanup the build
