[8u20] Review Request for RT-37732

Hello Steve, Kevin: I’de like to get this fix pushed into 8u20. mercurial: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/bc10f48ef71f jira: https://javafx-jira.kenai.com/browse/RT-37732 Small, self contained, limited impact, code new to 8u20, and it will make a huge difference for the assump

[8u20] review request: RT-37266: Need unit test that calls Platform.runLater from ShutdownHook

Anthony, Please review the following test-only fix: https://javafx-jira.kenai.com/browse/RT-37266 Thanks. -- Kevin

[8u20] review request: RT-37592, RT-37587, RT-37589 -- whitespace and copyright headers

David, Please review the following: https://javafx-jira.kenai.com/browse/RT-37592 (whitespace-only, but patch is needed if you want to apply either of the other two) https://javafx-jira.kenai.com/browse/RT-37587 -- Missing open source copyright headers on some source files https://javafx-

8u20 review request: RT-36341 - error loading image without extension on retina Mac

webrev: http://cr.openjdk.java.net/~flar/RT-36341/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36341 It will be hard to verify the test because webrev mangled the patch file on the test file, but any image file renamed to the appropriate file name should work as indicated in the com

[8u20] Review request forRT-15619: BMPImageLoader fails to correctly load an image if the input stream read(byte[] b, int off, int len) method happens to return fewer than 'len' bytes

Jim, Please review this very simple addition to the existing test: https://javafx-jira.kenai.com/browse/RT-15619 http://cr.openjdk.java.net/~vadim/RT-15619/webrev.00/ Thanks, Vadim

8u20 review request: RT-37475 shadow in Ensemble8 Puzzle Pieces demo gets erased

webrev: http://cr.openjdk.java.net/~flar/RT-37475/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37475 Lengthy explanation of an "aha" moment in the Jira, but the actual fix is fairly simple... ...jim

[8u20] review request: RT-37539: [Builders] Web builder classes not built unless COMPILE_WEBKIT=true

David, Please review the following simple patch. https://javafx-jira.kenai.com/browse/RT-37539 The patch is in the JIRA. -- Kevin

[8u20] Review request RT-34962 Ensemble: Speed Gauge stops animation after going back to main screen

Jasper, Please review the proposed fix for https://javafx-jira.kenai.com/browse/RT-34962 Details in jira. Thanks, Lisa

[8u20] Review request: RT-36240: Drag and Drop for complex datatypes fails with JavaFX embedded in Swing

Hi Steve, Please review: https://javafx-jira.kenai.com/browse/RT-36240 -- best regards, Anthony

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Hi Kevin, Please review the lambdification of the rt-tests component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have outstanding changes, please commit them and I will lambdify once more. Jira: https://javafx-jira.kenai.com/browse/R

[8u20] review request: RT-35912: [Ensemble8] build.xml fails if run from generated source bundle

Hi Lisa and David, Please review: https://javafx-jira.kenai.com/browse/RT-35912 Details are in JIRA. -- Kevin

[8u20] review request: RT-35004 Sample JavaFX 8 projects from Oracle wont build on NetBeans 8.0

Hi Kevin and David, Please review the proposed fix for: https://javafx-jira.kenai.com/browse/RT-35004 Details in the jira. Thanks, Lisa

[8u20] Review request: [FXCanvas, JFXPanel] NPE in Browser while pressing back/forward buttons from mouse

Hi Antony, Felipe, Please review: https://javafx-jira.kenai.com/browse/RT-37436 Steve

[8u20] Review request: RT-36361: [Accessibility] Mac: context menu hot key not working

Hi Felipe, Steve, Please review the fix: https://javafx-jira.kenai.com/browse/RT-36361 -- best regards, Anthony

8u20 review request: RT-37449 - use of Canvas PixelWriter leaves graphics in SRC mode

webrev: http://cr.openjdk.java.net/~flar/RT-37449/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37449 Simple fix, details in Jira comments... ...jim

8u20 review request: RT-36891: canvas does not clear correctly with clipping

webrev: http://cr.openjdk.java.net/~flar/RT-36891/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36891 Details are in the Jira comments... ...jim

8u20 review request RT-37434: Canvas dimensions not synchronous if bound

webrev: http://cr.openjdk.java.net/~flar/RT-37434/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-37434 Is there any other way for the properties to be updated that the new fix doesn't cover? ...jim

8u20 review request: RT-36016 dirty region problems with large blurs

webrev: http://cr.openjdk.java.net/~flar/RT-36016/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36016 This is a regression caused by the recent work on blurs/shadows on retina... ...jim

[8u20] Review request: RT-35953: [SwingNode] Swing component in JavaFx swing node no right click event

Hi Steve, Please review the fix: https://javafx-jira.kenai.com/browse/RT-35953 -- best regards, Anthony

[8u20] Review request for RT-20295: Error loading JPG image when scaling

Jim, Please review a fix for this: https://javafx-jira.kenai.com/browse/RT-20295 http://cr.openjdk.java.net/~vadim/RT-20295/webrev.00/ Thanks, Vadim

[8u20] Review request RT-37304: [Mac] handleOnMenuValidation may not be called when using system menu bar

Hi Steve, Petr, Please review the fix: https://javafx-jira.kenai.com/browse/RT-37304 -- best regards, Anthony

[8u20] Review request for RT-32213: Decoding BMP file throws an exception

Jim, Felipe, Kevin, Please review a fix for this: https://javafx-jira.kenai.com/browse/RT-32213 http://cr.openjdk.java.net/~vadim/RT-32213/webrev.00/ Thanks, Vadim

[8u20] Review request for RT-37026: Menubar menu item accelerators work only upon second pressing

Hi Steve, Please review the fix: https://javafx-jira.kenai.com/browse/RT-37026 -- best regards, Anthony

[8u20] Review request for RT-36956: [Swing] Not possible to select MenuItem in JFXPanel on Linux

Hi Alexander, Anton, Please review the fix: https://javafx-jira.kenai.com/browse/RT-36956 -- best regards, Anthony

[8u20] Review request: RT-37271: User presentable strings for accessibility are not translatable

Hi Felipe, Please review this fix and verify if you can that the strings still appear as expected in the AT software you are testing with. https://javafx-jira.kenai.com/browse/RT-37271 http://cr.openjdk.java.net/~leifs/rt37271/webrev.01/ Thanks, Leif

[8u20] Review request: RT-36660: [TextField] Arrow scrolling movement unexpected when text overflows

Hi Jonathan, Please review. https://javafx-jira.kenai.com/browse/RT-36660 http://cr.openjdk.java.net/~leifs/rt36660/webrev.01/ Thanks, Leif

[8u20] Review request for RT-37033: [SwingNode] JEditorPane in SwingNode inside TabPane does not get focus properly when clicked

Steve, Anton, Please review the fix for: https://javafx-jira.kenai.com/browse/RT-37033 -- best regards, Anthony

[8u20] Review request for RT-36957: [Gtk] Intermittent crash running system tests

Hi Alexander, Please review the fix: https://javafx-jira.kenai.com/browse/RT-36957 -- best regards, Anthony

[8u20] Review request for RT-32597: [SwingNode]: support high DPI displays

Jim, Kevin, Anton, Sergey, Please review: https://javafx-jira.kenai.com/browse/RT-32597 -- best regards, Anthony

[8u20] Review Request RT-36296 - app freeze with zero width dashed border

webrev: http://cr.openjdk.java.net/~flar/RT-36296/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36296 Do we need 2 reviewers? ...jim

[8u20] review request: RT-36760 - inner shadow displaced after fix for RT-13275

webrev: http://cr.openjdk.java.net/~flar/RT-36760/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-36760 ...jim

[8u20] Review request

Please review the fix for this OS X printing bug https://javafx-jira.kenai.com/browse/RT-35414 -phil.

[8u20] Review request for RT-36805: [Popup] Popup "steals" focus, when hiding the popup (regression)

Hi Steve, Kevin, Please review a fix for https://javafx-jira.kenai.com/browse/RT-36805 All the details are in JIRA. -- best regards, Anthony

[8u20] Review request for RT-36841: [Mac] Login demo may crash the JVM

Hi Petr, Steve, Please review a fix for https://javafx-jira.kenai.com/browse/RT-36841 -- best regards, Anthony

[8u20] Review request for RT-36340 - MT issues with GraphicsContext on unattached canvases

Jira: https://javafx-jira.kenai.com/browse/RT-36340 webrev: http://cr.openjdk.java.net/~flar/RT-36340/webrev.00/ ...jim

[8u20] Review Request for RT-36724 JavaFX Packager Renaming

Chris, Kevin, Steve, Please review the javafxpackager renaming changes, in the Jira Jira: https://javafx-jira.kenai.com/browse/RT-36724 WebRev: http://cr.openjdk.java.net/~shemnon/RT-36724/webrev.00/ The areas I most want reviewed are the bash script and the windows launcher, and I also want to

[8u20] Review request for RT-36823: Screen.getPrimary().getDpi() and Toolkit.getDefaultToolkit().getScreenResolution() returns different values

Hi Sergey, Felipe, Please review a fix for https://javafx-jira.kenai.com/browse/RT-36823 Please post your review comments in JIRA. Thanks. -- best regards, Anthony

[8u20] review request: RT-36790 dirty opts failure when vram shortage frees the back buffer

Jira: https://javafx-jira.kenai.com/browse/RT-36790 webrev: http://cr.openjdk.java.net/~flar/RT-36790/webrev.00/ ...jim

[8u20] Review request for RT-25570: [Menus, Mac] Mac OS : Menu.disable property is ignored when menu items are first initialized in the menu.onMenuValidation method

Hi Petr, Steve, Please review a fix for https://javafx-jira.kenai.com/browse/RT-25570 -- best regards, Anthony

[8u20] Review request for RT-36716: [Glass, Mac] Cannot show two transparent stages at the same time

Hi Petr, Steve, Please review a fix for https://javafx-jira.kenai.com/browse/RT-36716 -- best regards, Anthony

[8u20] Review request for RT-36487 : IMX6/monocle/touch - single touch events sequence is interpreted as multi-touch events

Hi Daniel, Would you please review the fix for https://javafx-jira.kenai.com/browse/RT-36487 ? A webrev is attached to the Jira. Thanks, Rafi

[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Hi Jim, Please review the lambdification of the buildSrc component (JSL portion). Strangely, there is only one file that is affected. Jira: https://javafx-jira.kenai.com/browse/RT-35197 Webrev: See patch in the JIRA Steve

[8u20] Review request for RT-35261: [Glass, French Keyboard] cannot type backquote in TextArea & TextField

Hi Steve, Felipe, Please review a fix for https://javafx-jira.kenai.com/browse/RT-35261 -- best regards, Anthony

[8u20] Review Request: RT-34737 MacGestureSupport.notifyNextTouchEvent IllegalStateException not on JavaFX Application Thread on exit

Hello, Anthony, Steve. Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-34737 Thank you. With best regards. Petr.

[8u20] Review request for RT-31272: Win: Window does not repaint after application collapse/expand via click icon on taskbar

Hi Felipe and Steve, Please review a fix for https://javafx-jira.kenai.com/browse/RT-31272 Details and the patch are in JIRA. -- best regards, Anthony

[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Hi Kevin, Please review the lambdification of the graphics component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you or any of the team have outstanding changes, please coordinate with me in the JIRA and I will re-lambdify after you have

[8u20] Review Request: RT-36293 [TouchEvent, PopupControl] Using a ListView in PopupControl generates a lot of TouchEvent NPE

Hello, Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-36293 Webrev: http://cr.openjdk.java.net/~pchelko/fx/36293/webrev/ With best regards. Petr.

8u20 review request: RT-24903 - Canvas does not always consume its rendering commands

webrev: http://cr.openjdk.java.net/~flar/RT-24903/webrev.01/ jira: https://javafx-jira.kenai.com/browse/RT-24903 ...jim

[8u20] Review request for RT-33475: NPE in PPSRenderer (when display disconnected?)

Jim, Kevin, Please review a fix for this: https://javafx-jira.kenai.com/browse/RT-33475 Thanks, Vadim

[8u20] Review request for RT-35025: Scene turns black sometimes.

Chien, Kevin, Please review a fix for this: http://cr.openjdk.java.net/~vadim/RT-35025/webrev.00/ https://javafx-jira.kenai.com/browse/RT-35025

[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Hi Jonathan, Please review the lambdification of the controls component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have outstanding changes, please commit them and I will lambdify once more. Jira: https://javafx-jira.kenai.com/bro

[8u20] review request: RT-35019: [3D] NPE in NGShape.renderContent when drawing empty shapes

Jim, Please review the following: https://javafx-jira.kenai.com/browse/RT-35019 Details are in JIRA. -- Kevin

[8u20] Review request for RT-35263: Win: Crashing VM in a JavaFX 3D app reading and writing STL files

Hi Felipe, Steve, Please review a fix for https://javafx-jira.kenai.com/browse/RT-35263 -- best regards, Anthony

[8u20] Review request for RT-36235: Zero specular power can lead to rendering artifacts.

Hi Chien, Kevin, Please review this fix: https://javafx-jira.kenai.com/browse/RT-36235 Thanks, Vadim

[8u20] Review request for RT-35681: Rendering difference between platforms when specular map is used

Hi Chien, Please review this simple fix: https://javafx-jira.kenai.com/browse/RT-35681 http://cr.openjdk.java.net/~vadim/RT-35681/webrev.00/ Thanks, Vadim

Re: 8u20 review request: RT-35635: new bundlers for fxpackager

This is an interim commit, the next one will be just a move to com.oracle.bundlers. I would consider those to be the definitive api going forward for the bundlers portion. The com.sun.javafx package implies that these are useful only for JavaFX, which is not the case since we are adding daemo

Re: 8u20 review request: RT-35635: new bundlers for fxpackager

Just out of curiousity, is there some reason that the new classes are in *com.oracle* and *com.sun* packages instead of just in a *javafx.tools*package? import com.oracle.bundlers.windows.WindowsBundlerParam; import com.sun.javafx.tools.packager.Log; import com.sun.javafx.tools.packager.bundlers.C

[8u20] Review request for RT-34283: [Swing] Drag&Drop with interop on Mac OS X between two processes does not transfer data

Hi Steve, Petr, Please review a fix for https://javafx-jira.kenai.com/browse/RT-34283 -- best regards, Anthony

Re: 8u20 review request: RT-35635: new bundlers for fxpackager

Dmitry, all, Please post your review notes to JIRA to keep all the information in one place. We use the mailing list to send out review requests so that other people could start watching the bug and/or join the review. The review itself should happen in JIRA comments. Thank you in advance. -

Re: 8u20 review request: RT-35635: new bundlers for fxpackager

Looks good to me. Thanks Dmitry On 3/13/14 11:08 PM, Danno Ferrin wrote: Kevin, Chris, Dmitry Please review. These are the new bundlers for the 8u20 packager, the daemon/services stuff Dmitry has been working on, and other related changes. It’s a big one so more eyes to find the stinkers bef

8u20 review request: RT-35635: new bundlers for fxpackager

Kevin, Chris, Dmitry Please review. These are the new bundlers for the 8u20 packager, the daemon/services stuff Dmitry has been working on, and other related changes. It’s a big one so more eyes to find the stinkers before it gets committed would be appreciated. Jira: https://javafx-jira.kena

8u20 review request: RT-36208: Exception using grayscale icon

Simple cut/paste error fix: Jira: https://javafx-jira.kenai.com/browse/RT-36208 webrev: http://cr.openjdk.java.net/~flar/RT-36208/webrev.00/ ...jim

[8u20] review request: RT-36189: [JFXPanel] SecurityException in PlatformUtil when running SwingInterop with security manager

Steve, Thomas, Please review the following fix: https://javafx-jira.kenai.com/browse/RT-36189 -- Kevin

Re: [8u20] review request: https://javafx-jira.kenai.com/browse/RT-36163

On 3/11/14, Mar 11, 6:21 PM, Kevin Rushforth wrote: David, Please review the (simple) build fix for: JIRA: https://javafx-jira.kenai.com/browse/RT-36163 Webrev: http://cr.openjdk.java.net/~kcr/RT-36163/ -- Kevin +1 -- David Hill Java Embedded Development Education: that which reveals to

[8u20] review request: https://javafx-jira.kenai.com/browse/RT-36163

David, Please review the (simple) build fix for: JIRA: https://javafx-jira.kenai.com/browse/RT-36163 Webrev: http://cr.openjdk.java.net/~kcr/RT-36163/ -- Kevin

[8u20] Review request for RT-20434: Image loading in j2d incorrectly handles gray scale

Jim, Kevin, Please review the fix: https://javafx-jira.kenai.com/browse/RT-20434 http://cr.openjdk.java.net/~vadim/RT-20434/webrev.00/ Thanks, Vadim

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Sorry everyone. The patch is there now. Steve On 2014-03-06 6:04 AM, Anthony Petrov wrote: No, it's not. Sorry. I guess Steve hasn't attached it to the JIRA. -- best regards, Anthony On 3/6/2014 2:12 PM, Anthony Petrov wrote: I believe the base-lambda.patch in JIRA is what you're looking f

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

No, it's not. Sorry. I guess Steve hasn't attached it to the JIRA. -- best regards, Anthony On 3/6/2014 2:12 PM, Anthony Petrov wrote: I believe the base-lambda.patch in JIRA is what you're looking for. -- best regards, Anthony On 3/6/2014 1:49 PM, Kirill Kirichenko wrote: I couldn't find m

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

I believe the base-lambda.patch in JIRA is what you're looking for. -- best regards, Anthony On 3/6/2014 1:49 PM, Kirill Kirichenko wrote: I couldn't find media part in Jira. On 06.03.2014 00:44, Stephen F Northover wrote: ... of course I mean the media component, not base. I just change the

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Follow this thread and open javafx Sent from my iPhone > On Mar 6, 2014, at 1:49 AM, Kirill Kirichenko > wrote: > > I couldn't find media part in Jira. > >> On 06.03.2014 00:44, Stephen F Northover wrote: >> ... of course I mean the media component, not base. I just change the >> template t

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

I couldn't find media part in Jira. On 06.03.2014 00:44, Stephen F Northover wrote: ... of course I mean the media component, not base. I just change the template to say "your component" ... Steve On 2014-03-05 3:41 PM, Stephen F Northover wrote: Hi Kirill, Please review the lambdification

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

.. of course I mean the media component, not base. I just change the template to say "your component" ... Steve On 2014-03-05 3:41 PM, Stephen F Northover wrote: Hi Kirill, Please review the lambdification of the base component. You are welcome to apply the patch, but there are numerous ch

[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Hi Kirill, Please review the lambdification of the base component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have outstanding changes, please commit them and I will lambdify once more, Jira: https://javafx-jira.kenai.com/browse/RT

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Of course I mean Leonid, who is the owner of web, not Anthony ... On 2014-03-04 1:18 PM, Stephen F Northover wrote: Hi Anthony, Please review the lambdification of the web component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have out

[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Hi Anthony, Please review the lambdification of the web component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have outstanding changes, please coordinate with me and I will re-lambdify to include the changes. Jira: https://javafx-jir

[8u20] Review request for RT-16923: The various addListener methods should throw NPE if a null listener is passed in, rather than throwing NPE when the listener list is iterated

Hi Felipe, Anthony, Please review this fix: https://javafx-jira.kenai.com/browse/RT-16923 http://cr.openjdk.java.net/~vadim/RT-16923/webrev.00/ Thanks, Vadim

8u20 review request: RT-35058 - Zoomy gets texture lock errors on ARM

webrev: http://cr.openjdk.java.net/~flar/RT-35058/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-35058 ...jim

[8u20] Review request: RT-21702 - [Touch, Windows] MouseEvents generated from touch-screen action have isSynthesized() == false

JIRA: https://javafx-jira.kenai.com/browse/RT-21702 Webrev: http://cr.openjdk.java.net/~ckyang/RT-21702/webrev.00/ Thanks, - Chien

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Hi Anthony, Please review the lambdification of the swing component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have outstanding changes, please coordinate with me and I will re-lambdify to include the changes. Jira: https://javafx-j

8u20 review request: RT-35452 - Canvas does not allow missing moveto in paths

webrev: http://cr.openjdk.java.net/~flar/RT-35452/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-35452 ...jim

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples [experiments]

Hi Lisa, Please review the lambdification of the experiments component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have outstanding changes, please coordinate with me and I will re-lambdify to include the changes. Jira: https://java

[8u20] Review request for RT-36038: [DND] FX sometimes forgets to invoke Node.onDragDetected() on Mac

Hi Steve, Please review a fix for https://javafx-jira.kenai.com/browse/RT-36038 -- best regards, Anthony

[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples [toys]

Hi Lisa, Please review the lambdification of the toys component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have outstanding changes, please coordinate with me and I will re-lambdify to include the changes. Jira: https://javafx-jira

Re: [8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

As a note to NB users, this may cause problems with NB 7.4 so if you use NB, and have problems with 7.4, you might want to try it with NB 8 RC1. -- Kevin Stephen F Northover wrote: Hi Martin, Please review the lambdification of the base component. You are welcome to apply the patch, but th

[8u20] Review request: RT-35197: Use Lambda in FX runtime and samples

Hi Martin, Please review the lambdification of the base component. You are welcome to apply the patch, but there are numerous changes and they are all automatic. If you have outstanding changes, please commit them and I will lambdify once more, Jira: https://javafx-jira.kenai.com/browse/RT

[8u20] Review request: RT-35976 [Linux, GTK] JavaFX X11 WM_CLASS

Hi Antony, Please review this simple fix. Jira: https://javafx-jira.kenai.com/browse/RT-35976 Webrev: http://cr.openjdk.java.net/~azvegint/fx/8u20/RT-35976/ -- -- Thanks, Alexander.

[8u20] Review request: RT-13275 - 0 radius blurs produce low resolution output

Kevin, Chien, Felipe, I'm tagging 3 people on this review to hopefully get some more critical feedback mostly because the webrev is large, though most of the changes are simple due to some method signature changes... Jira: https://javafx-jira.kenai.com/browse/RT-13275 webrev: http://cr.openjd

[8u20] Review request: RT-23406 & RT-21664

Hi Jonathan, please review the following: https://javafx-jira.kenai.com/browse/RT-23406 http://cr.openjdk.java.net/~msladecek/rt-23406/webrev.00/ https://javafx-jira.kenai.com/browse/RT-21664 http://cr.openjdk.java.net/~msladecek/rt-21664/webrev.00/ Thanks, -Martin

8u20 review request: RT-33294 - Canvas PixelWriter slow to fill canvas pixel by pixel

Jira: https://javafx-jira.kenai.com/browse/RT-33294 webrev: http://cr.openjdk.java.net/~flar/RT-33294/webrev.00/ Tested using the submitted test case and then also using all of the Canvas toys in rt-closed... ...jim

FX 8u20 review request: RT-25249 ImageInput does not update for changes to WritableImage

Jira: https://javafx-jira.kenai.com/browse/RT-25249 webrev: http://cr.openjdk.java.net/~flar/RT-25249/webrev.00/ The code was taken as a boilerplate from the ImageView code... ...jim

8u20 review request: RT-35443 Provide a headless glass implementation integrated with our JUnit tests

Hi Steve and Anthony, Would you review the following change to our build/test scripts to allow running JUnit tests in headless Monocle on desktop platforms? https://javafx-jira.kenai.com/browse/RT-35443 http://cr.openjdk.java.net/~dblaukop/webrev-20140121-1743-RT-35443/webrev/ Currently all tes

Re: 8u20 review request: RT-35355 - Software rendering ports of Monocle need notification of pixel upload end

Dave suggested another way of does this, which I tried out and it seemed to work. Notes and link to patch are in the JIRA. Either approach is OK with me, but others might feel more strongly about it. Daniel On Jan 16, 2014, at 10:31 PM, Daniel Blaukopf wrote: > Hi Kevin and Anthony, > > Wou

Re: 8u20 review request: RT-35355 - Software rendering ports of Monocle need notification of pixel upload end

Dave suggested another way of does this, which I tried out and it seemed to work. Notes and link to patch are in the JIRA. Either approach is OK with me, but others might feel more strongly about it. Daniel On Jan 16, 2014, at 10:31 PM, Daniel Blaukopf wrote: > Hi Kevin and Anthony, > > Wou

8u20 review request: RT-35355 - Software rendering ports of Monocle need notification of pixel upload end

Hi Kevin and Anthony, Would you review the following change to have Quantum notify Glass when it has finished rendering all scenes? This is to enable double-buffering on embedded and headless systems. https://javafx-jira.kenai.com/browse/RT-35355 http://cr.openjdk.java.net/~dblaukop/webrev-2014

8u20 review request: RT-35210 - exceptions in WebLauncher on Mac

Chien, Felipe, Jira: https://javafx-jira.kenai.com/browse/RT-35210 webrev: http://cr.openjdk.java.net/~flar/RT-35210/webrev.00/ I will finish the cleanup of the "shader log" logic (RT-35209) as a follow-on fix after this is pushed... ...jim

8u20 review request: RT-35209 - errors in the diagnostics in glContext.createProgram

Chien, Felipe, I've made some changes to the diagnostic code in glContext.c to help track down why WebLauncher is currently failing on Mac. I need a review and perhaps some help making sure that the changes compile on other platforms... Jira: https://javafx-jira.kenai.com/browse/RT-35209 we

[8u20] Review request for RT-32300: KeyCodes do not reflect the keys that are actually pressed on German keyboard

Hi Felipe, Steve, Please review a fix for https://javafx-jira.kenai.com/browse/RT-32300 -- best regards, Anthony

8u20 review request: RT-34854 - wrong stroke widths on texture-based primitives

It's a simple fix. I'm including Lisa on the reviewers because I'm surprised that this never showed up on embedded where the texture-based primitives are used by default...? Jira: https://javafx-jira.kenai.com/browse/RT-34854 webrev: http://cr.openjdk.java.net/~flar/RT-34854/webrev.00/ Tested