Re: [9] Review request: JDK-8170030 Code in Marlin-based rasterizers may have an off-by-1 bug

2016-12-09 Thread Laurent Bourgès
Dear Jim, Normally we'd isolate fixes for different bugs even if they are just > preparatory formatting changes on comments. > I agree but we are short on time and I consider those syntax changes are minor and without risk. Here is an updated webrev: http://cr.openjdk.java.net/~lbourges/marlinFX

Re: [9] Review request: JDK-8170030 Code in Marlin-based rasterizers may have an off-by-1 bug

2016-12-09 Thread Jim Graham
Hi Laurent, Normally we'd isolate fixes for different bugs even if they are just preparatory formatting changes on comments. Some comments on the formatting changes: line 35 - you should also upper-case the E line 148 - I don't understand why this "float" was a formatting danger, but the one

[9] Review request: JDK-8170030 Code in Marlin-based rasterizers may have an off-by-1 bug

2016-12-09 Thread Laurent Bourgès
Please review this simple fix for MarlinFX: JBS: https://bugs.openjdk.java.net/browse/JDK-8170030 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8170030.0/ PS: I will provide asap a Marlin2D patch incorporating changes made in MarlinFX (including this one) Cheers, Laurent