Looks good to me too.
--
Thanks,
Alexander.
On 28.07.2016 0:21, Kevin Rushforth wrote:
I have reviewed and tested the latest patch on Mac, Windows, Linux. I
added my approval to the JIRA.
Now we just one more reviewer.
Alexander Z or Sergey: are either of you able to review?
-- Kevin
Alex
I have reviewed and tested the latest patch on Mac, Windows, Linux. I
added my approval to the JIRA.
Now we just one more reviewer.
Alexander Z or Sergey: are either of you able to review?
-- Kevin
Alexander Nyssen wrote:
Hi Kevin,
sorry for that (I’m a Git guy and don’t feel very comforta
Hi Kevin,
sorry for that (I’m a Git guy and don’t feel very comfortable with Mercurial
yet). I have attached a revised patch that (hopefully) provides the correct
changes.
Regards,
Alexander
> Am 27.07.2016 um 18:51 schrieb Kevin Rushforth :
>
> I attached the patch to the JBS issue. You h
I attached the patch to the JBS issue. You have introduced a bug in the
SWTCursorsTest.java JUnit test -- it appears to be an almost-exact copy
of the manual test (including the now-incorrect class name). Also, you
have inadvertently included an unwanted modification to
.idea/modules.xml that s
Hi Kevin, all,
attached please find an updated patch and my replies to Kevin’s comments at
https://bugs.openjdk.java.net/browse/JDK-8088147:
> build.gradle
>
> 1. In the following:
>
> + if (IS_JIGSAW_TEST) {
> + enabled = false // FIXME: JIGSAW -- support this with modules
> + logger.inf
Picking this back up again, I have just added my comments to JBS issue.
https://bugs.openjdk.java.net/browse/JDK-8088147
The comments are minor in scope, so I suspect it will be ready for final
review after one more iteration. It will need one other reviewer, since
I am sponsoring the change.
I'm back, and given that the review will take some time anyway, I will
sponsor this once the review is complete. I see that Guru uploaded the
patch for you (thanks, Guru) so I can test it next week.
-- Kevin
Alexander Nyssen wrote:
It seems I was unsuccessful again. If somebody would be will
It seems I was unsuccessful again. If somebody would be willing to sponsor this
contribution while Kevin is away (or at least update the patch provided for
JDK-8088147), I could mail the patch privately.
Regards,
Alexander
> Am 11.07.2016 um 19:59 schrieb Alexander Nyssen :
>
> It seems my att
It seems my attachment has again been ‚consumed‘ by the list. Trying again with
an archive containing the patch file.
Regards,
Alexander
> Am 08.07.2016 um 23:28 schrieb Alexander Nyssen :
>
> Hi Kevin, all,
>
> attached please find a revised patch, where I have added the required export
>
Hi Kevin, all,
attached please find a revised patch, where I have added the required export to
PlatformImpl and have fixed the build script, so it does no longer break when
being executed in jigsaw mode.
As swt is no named module yet, I have disabled the JUnit test in jigsaw mode
for now. We
Hi Kevin,
> Am 30.06.2016 um 01:20 schrieb Kevin Rushforth :
>
> Hi Alexander,
>
> I attached the patch to the bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8088147
>
> If I build it and run the manual test in "legacy" mode, meaning run
> everything with 9+109 and the legacy jfxrt.jar fil
Hi Alexander,
I attached the patch to the bug:
https://bugs.openjdk.java.net/browse/JDK-8088147
If I build it and run the manual test in "legacy" mode, meaning run
everything with 9+109 and the legacy jfxrt.jar file, then it runs and
the cursor now changes. So this looks like a good starting
Hi Alexander,
It looks like your patch was stripped out by the mailing list server.
Can you please send me the patch offline, as a zip file (so line endings
are preserved across different systems), and I will unzip it and attach
it to the bug report.
-- Kevin
Alexander Nyssen wrote:
Hi,
Hi,
I have worked on a first contribution related to JDK-8088147. Attached please
find a patch (created in extended Git format) that comprises the related
changes. I have augmented the implementation of javafx.embed.swt.SWTCursors to
handle the image cursor case. I further adjusted javafx.scene
14 matches
Mail list logo
