Re: [Rev 01] RFR: 8242523: Update the animation and clip envelope classes

2020-06-01 Thread Ambarish Rapte
On Thu, 28 May 2020 16:44:33 GMT, Nir Lisker wrote: >> Mostly refactoring in preparation of the upcoming fixes. The changes might >> look like a lot, but it's mostly rearranging >> of methods. Summery of changes: >> ### Animation >> * Added `isNearZero` and `areNearEqual` methods that deal with

Re: [Rev 01] RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Kevin Rushforth
On Thu, 28 May 2020 16:44:33 GMT, Nir Lisker wrote: >> Mostly refactoring in preparation of the upcoming fixes. The changes might >> look like a lot, but it's mostly rearranging >> of methods. Summery of changes: >> ### Animation >> * Added `isNearZero` and `areNearEqual` methods that deal with

Re: [Rev 01] RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Nir Lisker
On Thu, 28 May 2020 15:51:19 GMT, Kevin Rushforth wrote: >> Doesn't the autogenerated JavaDoc for the `getX`, `setX` and `xProperty` >> methods work by matching the method name to >> the property name regardless of they location in the class? >> `doSetCurrentRate` shouldn't ever be able to

Re: [Rev 01] RFR: 8242523: Update the animation and clip envelope classes

2020-05-28 Thread Nir Lisker
> Mostly refactoring in preparation of the upcoming fixes. The changes might > look like a lot, but it's mostly rearranging > of methods. Summery of changes: > ### Animation > * Added `isNearZero` and `areNearEqual` methods that deal with `EPSILON` > checks. > * Added `isStopped`, `isRunning`