On Tue, 5 May 2020 11:07:43 GMT, Ajit Ghaisas wrote:
>> Issue :
>> https://bugs.openjdk.java.net/browse/JDK-8244110
>>
>> Root Cause :
>> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
>> code to remove accelerators from a scene
>> in Scene property listener of
On Tue, 5 May 2020 13:53:02 GMT, Jeanette Winzenburg
wrote:
>
>
> not sure if it is appropriate to approve this? we talked so much about it,
> that it feels like self-approval :)
Please do approve it. And thank you for contributing the solution and test.
-
PR:
On Tue, 5 May 2020 12:38:26 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make ChangeListener Final
>
> Looks good. I confirm that the original system test and the new controls unit
> test
On Tue, 5 May 2020 11:07:43 GMT, Ajit Ghaisas wrote:
>> Issue :
>> https://bugs.openjdk.java.net/browse/JDK-8244110
>>
>> Root Cause :
>> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
>> code to remove accelerators from a scene
>> in Scene property listener of
On Tue, 5 May 2020 10:35:12 GMT, Ajit Ghaisas wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuButtonSkinBase.java
>> line 230:
>>
>>> 229: // Remove listeners
>>> 230:
>>> getSkinnable().sceneProperty().removeListener(sceneChangeListener);
>>>
> Issue :
> https://bugs.openjdk.java.net/browse/JDK-8244110
>
> Root Cause :
> Fix of [JDK-8175358](https://bugs.openjdk.java.net/browse/JDK-8175358) added
> code to remove accelerators from a scene
> in Scene property listener of MenuButtonSkinBase. That fix uses
> getSkinnable() in listener.
On Mon, 4 May 2020 15:46:57 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make ChangeListener Final
>
>
