On Tue, 17 Dec 2019 21:37:34 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java
> line 63:
>
>> 62: @Test(timeout = 15000)
>> 63: public void
On Thu, 19 Dec 2019 14:13:47 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java
> line 64:
>
>> 63: public void dialogWithOwnerSizingTest() throws Exception
On Tue, 17 Dec 2019 23:01:51 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> tests/system/src/test/java/test/robot/javafx/scene/dialog/DialogWithOwnerSizingTest.java
> line 124:
>
>> 123:
>> 124:
On Thu, 19 Dec 2019 14:29:39 GMT, Ambarish Rapte wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1062:
>
>> 1061: geometry.final_height.type = BOUNDSTYPE_CONTENT;
>> 1062: }
>> 1063:
On Thu, 19 Dec 2019 14:32:32 GMT, Thiago Milczarek Sayao
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8232811
>>
>> This one was hard to tackle.
>>
>> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
>> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
>
>
On Tue, 17 Dec 2019 21:43:19 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks good (with a minor formatting comment). The test needs a couple
> of changes.
@arapte - can you be the second reviewer on this?
-
PR:
On Tue, 17 Dec 2019 23:02:02 GMT, Thiago Milczarek Sayao
wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8232811
>>
>> This one was hard to tackle.
>>
>> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
>> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
>
>
> https://bugs.openjdk.java.net/browse/JDK-8232811
>
> This one was hard to tackle.
>
> ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests
> test.robot.javafx.scene.dialog.DialogWithOwnerSizingTest
The pull request has been updated with 1 additional commit.
-
