On Sat, 13 Jun 2020 15:03:00 GMT, Kevin Rushforth wrote:
>> darn .. overlooked that fixed index ..
>>
>> As to the naming: personally, I hate violation of naming conventions even
>> for test-only methods, so would tend to make
>> setFocusedMenuIndex package and doc as being used for testing
On Sat, 13 Jun 2020 09:06:01 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java
>> line 764:
>>
>>> 763: void setFocusedIndex(int index) {
>>> 764: this.setFocusedMenuIndex(0);
>>> 765: }
>>
>> Shouldn't this be
On Fri, 12 Jun 2020 21:17:09 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review fixes and test addition
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/MenuBarSkin.java
On Mon, 18 May 2020 05:52:21 GMT, Ajit Ghaisas wrote:
>> Issue :
>> https://bugs.openjdk.java.net/browse/JDK-8244418
>>
>> Root Cause :
>> Incorrect assumption about menu list size.
>>
>> Fix :
>> Added check for empty menu list before trying to access it.
>>
>> Test :
>> Added a unit test
On Mon, 18 May 2020 05:52:21 GMT, Ajit Ghaisas wrote:
>> Issue :
>> https://bugs.openjdk.java.net/browse/JDK-8244418
>>
>> Root Cause :
>> Incorrect assumption about menu list size.
>>
>> Fix :
>> Added check for empty menu list before trying to access it.
>>
>> Test :
>> Added a unit test
On Mon, 18 May 2020 05:42:17 GMT, Ajit Ghaisas wrote:
>> hmm .. yeah I'm aware of getContainer vs. getMenus - but they should be the
>> same size, shouldn't they?
>>
>> Anyway, if focusedIndex != getMenus().indexOf all users of focusedIndex have
>> to include a check for validity. That
>>
> Issue :
> https://bugs.openjdk.java.net/browse/JDK-8244418
>
> Root Cause :
> Incorrect assumption about menu list size.
>
> Fix :
> Added check for empty menu list before trying to access it.
>
> Test :
> Added a unit test that fails before fix and passes after it.
Ajit Ghaisas has updated
On Fri, 15 May 2020 09:29:27 GMT, Jeanette Winzenburg
wrote:
>> I differ on this suggestion.
>> My thinking is - list access in setFocusedMenuIndex() method should have
>> this check. It is not up to the caller to know
>> the internal details of the method. That's the root cause of Exception.
