Re: [Rev 04] RFR: 8217472: Add attenuation for PointLight

2020-05-13 Thread Kevin Rushforth
On Wed, 13 May 2020 23:42:40 GMT, Nir Lisker wrote: >> If this were an even remotely representative use case, then no, the >> performance hit would not be OK. The test was >> designed as an artificial "worst-case" stress test: a single mesh with a >> large number of very large (window-sized) >>

Re: [Rev 04] RFR: 8217472: Add attenuation for PointLight

2020-05-13 Thread Nir Lisker
On Sat, 25 Apr 2020 17:07:21 GMT, Kevin Rushforth wrote: > We should make sure that we aren't seeing any significant performance drop > when rendering spheres (at a couple > different tessellation levels) or boxes. I missed this. Do you mean that the test should create a mesh of a sphere inste

Re: [Rev 04] RFR: 8217472: Add attenuation for PointLight

2020-05-08 Thread Nir Lisker
> CSR: https://bugs.openjdk.java.net/browse/JDK-8218264 Nir Lisker has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits: - Merge branch 'master' into 8217472_Add_attenuation_for_PointLight - Attenuation and range changed inter