Re: [graphics] [9] Review request for 8155903: Crash while running imported/w3c/canvas/2d.gradient.interpolate.overlap2.html

2016-05-10 Thread Arunprasad Rajkumar
Hello Jim, Thank you. Incorporated your review comments in http://cr.openjdk.java.net/~arajkumar/8155903/webrev.03 Please take a look. -- Arun On 5/9/2016 11:51 PM, Jim Graham wrote: That looks good for the case where Imin is zero, but it appears that we could also have overflow as well,

Re: [graphics] [9] Review request for 8155903: Crash while running imported/w3c/canvas/2d.gradient.interpolate.overlap2.html

2016-05-09 Thread Jim Graham
That looks good for the case where Imin is zero, but it appears that we could also have overflow as well, with a single very tiny Imin the accumulation of estimatedSize with an "int" type could easily overflow and become essentially a random number. Changing the estimatedSize variable to a

Re: [graphics] [9] Review request for 8155903: Crash while running imported/w3c/canvas/2d.gradient.interpolate.overlap2.html

2016-05-09 Thread Arunprasad Rajkumar
Hello Jim, Thanks for your suggestions. As of now I taking an easy way to fix the issue, New changes are available at http://cr.openjdk.java.net/~arajkumar/8155903/webrev.02 I couldn't write a reliable test case using public javafx APIs, the behavior is intermittent. However I could

[graphics] [9] Review request for 8155903: Crash while running imported/w3c/canvas/2d.gradient.interpolate.overlap2.html

2016-05-05 Thread Arunprasad Rajkumar
Hello Jim, Please review the below patch. JIRA: https://bugs.openjdk.java.net/browse/JDK-8155903 Webrev: http://cr.openjdk.java.net/~arajkumar/8155903/webrev.01 Issue: Divide by zero while adding multiple gradient stops at same offset. Regards, Arun