Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-07 Thread Nir Lisker
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to `Light

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-07 Thread Ambarish Rapte
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to `Light

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Kevin Rushforth
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to `Light

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Nir Lisker
On Thu, 27 Jan 2022 19:01:32 GMT, Kevin Rushforth wrote: >> I think the description should focus on the meaning of the respective term >> in the lighting equation, and not on a non-technical analogy. In this case, >> the analogy is a bit misleading on several aspects, including the fact that >

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Nir Lisker
> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share characteristics