Re: Exposed implementation details in DateTimeStringConverter

2021-01-26 Thread Nir Lisker
Yes, sorry, I should have been more clear. Only dateFormat is used during runtime, the other 4 are used only during construction to create a DateFormat if one is not given, they shouldn't even be fields. dateFormat encodes all the information of the converter and has a getter (also protected access

Re: Exposed implementation details in DateTimeStringConverter

2021-01-26 Thread Kevin Rushforth
I presume you mean these three?     protected final Locale locale;     protected final String pattern;     protected final DateFormat dateFormat; and maybe also these two?     /** * @since JavaFX 8u40 */     protected final int dateStyle;     /** * @since JavaFX 8u40 */    

Exposed implementation details in DateTimeStringConverter

2021-01-26 Thread Nir Lisker
Hi, DateTimeStringConverter exposes final protected fields that are used for internal implementation. These fields should have been private or package-private. The reasons are: 1. A comment above them refers to them as private fields. 2. They have no documentation attached. 3. They are useless to