Re: Re: Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-25 Thread Johan Vos
I agree. The availability of assertThrows and assertDoesNotThrows is already a justification for jUnit 5, imho. - Johan Op za 25 sep. 2021 om 17:58 schreef Marius Hanl : >I also really like this move, thanks for that. > >I have also experience with JUnit 5. >And if there is

Re: Re: Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-25 Thread Marius Hanl
I also really like this move, thanks for that. I have also experience with JUnit 5. And if there is something where I may can help I'm glad to do so. For people who may don't know, this are the features JUnit5 gives us and I'm also excited about: - assertThrows(..) -

Re: Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-25 Thread Kevin Rushforth
I also see advantages in moving to JUnit 5, given that we can still support both JUint 4 and JUnit 5 in the same project using jupiter-vintage (thus avoiding the need to rewrite existing tests). Do any other contributors have experiences with JUnit 5 that they could share? -- Kevin On

Re: Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-25 Thread Nir Lisker
I much prefer JUnit 5 to 4, so I'm in favor. On Sat, Sep 25, 2021 at 12:40 AM John Hendrikx wrote: > Posting this to gauge the interest in adding JUnit 5 as a test > dependency to JavaFX, enabling writing tests with this new version of > JUnit while still supporting all JUnit 4 tests. > > A

Gauging interest in updating the JavaFX test framework with JUnit 5

2021-09-24 Thread John Hendrikx
Posting this to gauge the interest in adding JUnit 5 as a test dependency to JavaFX, enabling writing tests with this new version of JUnit while still supporting all JUnit 4 tests. A draft PR has been submitted here: https://github.com/openjdk/jfx/pull/633 And an issue has been filed here: