Re: JDK-8193445 Performance Test (CSS applied redundantly)

2019-01-18 Thread Dean Wookey
The last time the issue was discussed was in November. You can see the thread here: https://mail.openjdk.java.net/pipermail/openjfx-dev/2018-November/022837.html I too would like to see this and other performance issues addressed (although our actual biggest priority is mobile). Right now my team

Re: JDK-8193445 Performance Test (CSS applied redundantly)

2019-01-17 Thread Scott Palmer
> On Jan 17, 2019, at 3:23 PM, Tom Schindl wrote: > > Sorry to hi-jack but: > >> Performance improvements and a JNI mechanism to get at native window handles >> are the first two items on my wish list. Though extendable media support >> could potentially beat out the window handle thing.. I

Re: JDK-8193445 Performance Test (CSS applied redundantly)

2019-01-17 Thread Tom Schindl
Sorry to hi-jack but: > Performance improvements and a JNI mechanism to get at native window handles > are the first two items on my wish list. Though extendable media support > could potentially beat out the window handle thing.. I only need a native > window handle so I can do native renderi

Re: JDK-8193445 Performance Test (CSS applied redundantly)

2019-01-17 Thread Scott Palmer
JDK-8183100 is a fixed issue. But it basically undid the fix for https://bugs.openjdk.java.net/browse/JDK-8151756 I think you mean to ask when JDK-8193445 might be addressed. I too would like to see the performance return, and actually I’m hopi

Re: JDK-8193445 Performance Test (CSS applied redundantly)

2019-01-17 Thread daniel.weil
Does anybody has any information about a target release for fixing https://bugs.openjdk.java.net/browse/JDK-8183100 , this issue causing severe performance degradation since JDK1.8.172? Since JDK1.8.182, CSS is applied redundantly, leading too significant performance degradation, on scenes with

Re: JDK-8193445 Performance Test

2018-11-07 Thread Dean Wookey
Hi, I just wanted to clarify a few things about the fix. The test I showed hints at a potentially safer way to implement the fix for this problem. One would expect adding nodes 1 by 1 to the scene graph to be less efficient than adding them all at once, but it's far worse to add them all at once.

Re: JDK-8193445 Performance Test

2018-11-07 Thread Kevin Rushforth
My thoughts as well. I would love to see a safe robust fix for this issue, but there is a very real possibility of a regression: We thought we had a safe fix earlier and only later discovered the (multiple) regressions a few months after it was released. One possible way to improve performance

Re: JDK-8193445 Performance Test

2018-11-07 Thread Scott Palmer
> On Nov 7, 2018, at 8:37 AM, David Grieve wrote: > > ... > > Reapplying CSS to a Node but not its children could cause a problem if there > are styles in the parent or the parent's parents that affect the children. It > seems like bypassing children in reapplyCSS is bound to cause a regres

Re: JDK-8193445 Performance Test

2018-11-07 Thread David Grieve
One of the dangers of mucking around with the CSS code is whether or not the changes break things like popups, dialogs, menus. And whether or not the change breaks inline styles versus attributes set in code, versus stylesheets added to the scene/subscene/control, versus default stylesheets. An

JDK-8193445 Performance Test

2018-11-07 Thread Dean Wookey
Hi, I was going to ask if it was possible to reopen JDK-8151756 ( https://bugs.openjdk.java.net/browse/JDK-8151756) since it was fixed but reverted in JDK-8183100 (https://bugs.openjdk.java.net/browse/JDK-8183100) after causing several regressions. I only noticed now that a followup bug was create