Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2021-01-12 Thread Kevin Rushforth
On Sun, 26 Apr 2020 10:42:10 GMT, Jeanette Winzenburg wrote: >>> repeating my comment from the [previous pull >>> request](https://github.com/openjdk/jfx/pull/136#issuecomment-608401086): I >>> don't think this is yet ready for a technical review - there are some more >>> basic questions

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-26 Thread Jeanette Winzenburg
On Sun, 19 Apr 2020 10:37:56 GMT, Craig Cavanaugh wrote: >For me / my users / and the open bug, it is a bug due to the current > behavior being unexpected. It creates the >illusion of a preselected value not actually being selected because it's > not visible if the list is large and

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-19 Thread Craig Cavanaugh
On Fri, 17 Apr 2020 10:42:30 GMT, Jeanette Winzenburg wrote: > repeating my comment from the [previous pull > request](https://github.com/openjdk/jfx/pull/136#issuecomment-608401086): > I don't think this is yet ready for a technical review - there are some more > basic questions that are not

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-18 Thread Kevin Rushforth
On Fri, 17 Apr 2020 10:42:30 GMT, Jeanette Winzenburg wrote: >> I think, selection and scrolling are two separate operations. Here we use >> these two operations to achieve the desired >> result for ComboBox. It is nice to have behavior and I am OK with the fix. >>> Also, I believe

Re: [Rev 01] RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-18 Thread Craig Cavanaugh
On Fri, 17 Apr 2020 10:38:06 GMT, Ajit Ghaisas wrote: >> Craig Cavanaugh has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update unit test for JDK_8129123 to check midpoint of the list > >

Re: [Rev 01] RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-18 Thread Craig Cavanaugh
> https://bugs.openjdk.java.net/browse/JDK-8129123 > > This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and > Windows 10.

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Jeanette Winzenburg
On Fri, 17 Apr 2020 10:34:54 GMT, Ajit Ghaisas wrote: >> That did it! >> >> Thanks! >> >> On Thu, Apr 16, 2020 at 8:30 AM Kevin Rushforth >> wrote: >> >>> The following should work: >>> >>> $ git rebase -i master >>> >>> If the rebase is successful, it will pop you into your EDITOR. You then

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Ajit Ghaisas
On Thu, 9 Apr 2020 09:37:30 GMT, Craig Cavanaugh wrote: > https://bugs.openjdk.java.net/browse/JDK-8129123 > > This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Ajit Ghaisas
On Fri, 17 Apr 2020 09:21:25 GMT, Craig Cavanaugh wrote: >> The following should work: >> >> $ git rebase -i master >> >> If the rebase is successful, it will pop you into your EDITOR. You then >> select "pick" for the first commit (which is >> already selected by default) and "s"quash or

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Ajit Ghaisas
On Fri, 10 Apr 2020 10:22:29 GMT, Jeanette Winzenburg wrote: >> https://bugs.openjdk.java.net/browse/JDK-8129123 >> >> This pull request fixes JDK-8129123. This bug also effects Windows and Linux >> platforms. >> Also, I believe JDK-8196037 is a duplicate of this issue. >> >> I've tested

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Kevin Rushforth
On Tue, 14 Apr 2020 10:43:30 GMT, Craig Cavanaugh wrote: >> I am taking a look at your changes now. >> @ccavanaugh can you make jcheck pass while I review. Please see the details >> of the failing jcheck. > > Thank you. I've updated the pull request comments with what I thought was > the

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Craig Cavanaugh
On Tue, 14 Apr 2020 11:11:13 GMT, Kevin Rushforth wrote: >> Thank you. I've updated the pull request comments with what I thought was >> the necessary changes, but jcheck is still failing with >> >> "the commits in this PR have inconsistent user names and/or email >> addresses. Please amend

RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Craig Cavanaugh
https://bugs.openjdk.java.net/browse/JDK-8129123 This pull request fixes JDK-8129123. This bug also effects Windows and Linux platforms. Also, I believe JDK-8196037 is a duplicate of this issue. I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and Windows 10. Thanks!

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Craig Cavanaugh
On Thu, 16 Apr 2020 12:30:20 GMT, Kevin Rushforth wrote: >> Seems I've made a further mess attempting to rebase. I apologize as I know >> the list is not intended to be tech support for git usage, but I'm at a >> loss and don't want to make it worse. >> >> Below is the log after an interactive

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Jeanette Winzenburg
On Thu, 9 Apr 2020 09:37:30 GMT, Craig Cavanaugh wrote: > https://bugs.openjdk.java.net/browse/JDK-8129123 > > This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Kevin Rushforth
On Thu, 16 Apr 2020 10:01:14 GMT, Craig Cavanaugh wrote: >> I think you will need to rebase and force push your branch. > > Seems I've made a further mess attempting to rebase. I apologize as I know > the list is not intended to be tech support for git usage, but I'm at a > loss and don't want

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-17 Thread Craig Cavanaugh
On Tue, 14 Apr 2020 09:04:40 GMT, Ajit Ghaisas wrote: >> was: https://github.com/openjdk/jfx/pull/136 > > I am taking a look at your changes now. > @ccavanaugh can you make jcheck pass while I review. Please see the details > of the failing jcheck. Thank you. I've updated the pull request

Re: [Rev 02] RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-09 Thread Craig Cavanaugh
> This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and > Windows 10. > > Thanks! Craig Cavanaugh has refreshed the

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-04 Thread Craig Cavanaugh
My use case which is driving the fix for this bug is user expectation in an open source application (https://github.com/ccavanaugh/jgnash). When a user makes an edit to an existing transaction, the expectation is the prior selected ComboBox value is visible when the list is displayed, otherwise

Re: [Rev 01] RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-04 Thread Craig Cavanaugh
> This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and > Windows 10. > > Thanks! Craig Cavanaugh has updated the pull

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-03 Thread Jeanette Winzenburg
On Fri, 3 Apr 2020 12:03:33 GMT, Jeanette Winzenburg wrote: >>> Can you please provide a unit test? One that fails before your fix and >>> passes after your fix. >> >> I can provide a manual test the next couple of days that demonstrates it >> before and after, but I'm not sure how to >>

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-03 Thread Jeanette Winzenburg
On Thu, 2 Apr 2020 23:28:19 GMT, Craig Cavanaugh wrote: >> Can you please provide a unit test? One that fails before your fix and >> passes after your fix. > >> Can you please provide a unit test? One that fails before your fix and >> passes after your fix. > > I can provide a manual test

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-02 Thread Craig Cavanaugh
On Thu, 2 Apr 2020 22:20:18 GMT, Kevin Rushforth wrote: > Can you please provide a unit test? One that fails before your fix and passes > after your fix. I can provide a manual test the next couple of days that demonstrates it before and after, but I'm not sure how to create an automated unit

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-02 Thread Kevin Rushforth
On Thu, 2 Apr 2020 22:20:18 GMT, Kevin Rushforth wrote: >> This pull request fixes JDK-8129123. This bug also effects Windows and >> Linux platforms. >> Also, I believe JDK-8196037 is a duplicate of this issue. >> >> I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and >>

Re: RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-02 Thread Kevin Rushforth
On Wed, 4 Mar 2020 22:43:45 GMT, Craig Cavanaugh wrote: > This pull request fixes JDK-8129123. This bug also effects Windows and Linux > platforms. > Also, I believe JDK-8196037 is a duplicate of this issue. > > I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and >

RFR: 8129123: ComboBox popup list view does not scrollTo when ComboBox value/selection is set

2020-04-02 Thread Craig Cavanaugh
This pull request fixes JDK-8129123. This bug also effects Windows and Linux platforms. Also, I believe JDK-8196037 is a duplicate of this issue. I've tested this against OpenJDK 11.0.6 on Ubuntu 18.04, Arch Linux and Windows 10. Thanks! - Commit messages: - Merge branch