Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v5]

2022-01-02 Thread Martin Fox
On Mon, 20 Dec 2021 12:11:11 GMT, Johan Vos wrote: >> Martin Fox has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits sinc

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v5]

2021-12-20 Thread Martin Fox
On Thu, 16 Dec 2021 21:40:47 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY l

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v5]

2021-12-20 Thread Johan Vos
On Thu, 16 Dec 2021 21:40:47 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY l

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v5]

2021-12-16 Thread Martin Fox
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as > expected by more accurately mapping from a Mac key code to a Java key code > based on the user’s active keyboard layout (the existing code assumes a US > QWERTY layout). The new code first identifies a set of Mac keys wh