Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-10 Thread Jeanette Winzenburg
On Tue, 8 Feb 2022 12:49:59 GMT, Marius Hanl wrote: >> Issue was TreeView commit editing implementation violated the spec'ed >> mechanism: >> >> - no default commit handler on TreeView >> - TreeCell modifying the data directly >> >> Fix is to move the saving of the edited value from cell into

Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-09 Thread Ajit Ghaisas
On Wed, 9 Feb 2022 14:04:55 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TreeView.java >> line 341: >> >>> 339: setFocusModel(new TreeViewFocusModel(this)); >>> 340: >>> 341: setOnEditCommit(DEFAULT_EDIT_COMMIT_HANDLER); >> >>

Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-09 Thread Ajit Ghaisas
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg wrote: > Issue was TreeView commit editing implementation violated the spec'ed > mechanism: > > - no default commit handler on TreeView > - TreeCell modifying the data directly > > Fix is to move the saving of the edited value from cell

Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-09 Thread Jeanette Winzenburg
On Wed, 9 Feb 2022 10:51:54 GMT, Ajit Ghaisas wrote: >> Issue was TreeView commit editing implementation violated the spec'ed >> mechanism: >> >> - no default commit handler on TreeView >> - TreeCell modifying the data directly >> >> Fix is to move the saving of the edited value from cell

Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-09 Thread Ajit Ghaisas
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg wrote: > Issue was TreeView commit editing implementation violated the spec'ed > mechanism: > > - no default commit handler on TreeView > - TreeCell modifying the data directly > > Fix is to move the saving of the edited value from cell

Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-08 Thread Marius Hanl
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg wrote: > Issue was TreeView commit editing implementation violated the spec'ed > mechanism: > > - no default commit handler on TreeView > - TreeCell modifying the data directly > > Fix is to move the saving of the edited value from cell

Re: RFR: 8187309: TreeCell must not change tree's data

2022-02-07 Thread Michael Strauß
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg wrote: > Issue was TreeView commit editing implementation violated the spec'ed > mechanism: > > - no default commit handler on TreeView > - TreeCell modifying the data directly > > Fix is to move the saving of the edited value from cell

RFR: 8187309: TreeCell must not change tree's data

2022-02-02 Thread Jeanette Winzenburg
Issue was TreeView commit editing implementation violated the spec'ed mechanism: - no default commit handler on TreeView - TreeCell modifying the data directly Fix is to move the saving of the edited value from cell into a default commit handler in tree and set that handler in the constructor.