On Thu, 25 Jun 2020 22:45:17 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comment corrections, adding new tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/T
On Thu, 25 Jun 2020 22:48:07 GMT, Kevin Rushforth wrote:
>
>
> The changes to the fix itself look fine. I have a question and minor comment
> on the test changes.
>
> As for the questions raised by @kleopatra as long as you plan to address them
> in the follow-up issue(s), that seems
> fine,
On Thu, 25 Jun 2020 22:44:18 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comment corrections, adding new tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/T
On Wed, 24 Jun 2020 11:02:53 GMT, Ambarish Rapte wrote:
>> Issue:
>> In TreeTableView, in case of Multiple selection mode, if nested items are
>> selected, then TreeTableView does not
>> retain/update the selection correctly when the tree items are
>> permuted(either by `sort()` or by reorderin
> Issue:
> In TreeTableView, in case of Multiple selection mode, if nested items are
> selected, then TreeTableView does not
> retain/update the selection correctly when the tree items are permuted(either
> by `sort()` or by reordering using
> `setAll()`). Cause:
>
> 1. For permutation, the cur
