Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-06-01 Thread Michael Ennen
On Mon, 2 May 2022 19:55:28 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time in order to confine the scope of >> the

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-06 Thread Nir Lisker
On Fri, 6 May 2022 14:13:55 GMT, Michael Strauß wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unused comments, clean constructor > > modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.cc line 149:

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-06 Thread Nir Lisker
On Fri, 6 May 2022 14:09:13 GMT, Michael Strauß wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unused comments, clean constructor > > modules/javafx.graphics/src/main/native-prism-d3d/D3DLight.h line 34: > >

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-06 Thread Nir Lisker
On Fri, 6 May 2022 14:21:58 GMT, Michael Strauß wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove unused comments, clean constructor > > modules/javafx.graphics/src/main/native-prism-d3d/D3DMeshView.h line 61: >

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-06 Thread Michael Strauß
On Mon, 2 May 2022 19:55:28 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time in order to confine the scope of >> the

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-05-02 Thread Nir Lisker
> Refactoring and renaming changes to some of the D3D pipeline files and a few > changes on the Java side. These are various "leftovers" from previous issues > that we didn't want to touch at the time in order to confine the scope of the > changes. They will make future work easier. > > Since t

RFR: 8217853: Cleanup in the D3D native pipeline

2022-05-02 Thread Nir Lisker
Refactoring and renaming changes to some of the D3D pipeline files and a few changes on the Java side. These are various "leftovers" from previous issues that we didn't want to touch at the time in order to confine the scope of the changes. They will make future work easier. Since there are man