Re: RFR: 8223296: NullPointerException in GlassScene.java at line 325

2019-12-13 Thread Kevin Rushforth
On Fri, 13 Dec 2019 10:48:37 GMT, Ambarish Rapte wrote: >>> This is moved only to make first operation when disposing. However the race >>> condition is very rare, but this will just reduce the chances little more. >> >> Can you elaborate? Why would there still be a race condition? > >> Can

Re: RFR: 8223296: NullPointerException in GlassScene.java at line 325

2019-12-13 Thread Kevin Rushforth
On Tue, 10 Dec 2019 07:00:50 GMT, Ambarish Rapte wrote: > Issue: NPE in GlassScene.frameRendered(). > > Cause: scenePaintListener is set in setTKScenePaintListener(), used in > frameRendered() and > set to null in dispose(). > setTKScenePaintListener() and dispose() are called on JavaFX

Re: RFR: 8223296: NullPointerException in GlassScene.java at line 325

2019-12-12 Thread Kevin Rushforth
On Wed, 11 Dec 2019 17:10:37 GMT, Ambarish Rapte wrote: >> The change looks OK as far as it goes, meaning that it will fix the specific >> NPE reported by the bug and is looks like a safe fix. >> >> Two questions: >> >> 1. In addition to calling the synchronized `setTKScenePaintListener`

Re: RFR: 8223296: NullPointerException in GlassScene.java at line 325

2019-12-11 Thread Ambarish Rapte
On Tue, 10 Dec 2019 16:27:10 GMT, Kevin Rushforth wrote: >> Issue: NPE in GlassScene.frameRendered(). >> >> Cause: scenePaintListener is set in setTKScenePaintListener(), used in >> frameRendered() and >> set to null in dispose(). >> setTKScenePaintListener() and dispose() are called on

Re: RFR: 8223296: NullPointerException in GlassScene.java at line 325

2019-12-10 Thread Kevin Rushforth
On Tue, 10 Dec 2019 07:00:50 GMT, Ambarish Rapte wrote: > Issue: NPE in GlassScene.frameRendered(). > > Cause: scenePaintListener is set in setTKScenePaintListener(), used in > frameRendered() and > set to null in dispose(). > setTKScenePaintListener() and dispose() are called on JavaFX

RFR: 8223296: NullPointerException in GlassScene.java at line 325

2019-12-09 Thread Ambarish Rapte
Issue: NPE in GlassScene.frameRendered(). Cause: scenePaintListener is set in setTKScenePaintListener(), used in frameRendered() and set to null in dispose(). setTKScenePaintListener() and dispose() are called on JavaFX Application Thread and frameRendered() is called by QuantumRenderer