Re: [Approved] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Ambarish Rapte
On Tue, 19 Nov 2019 19:17:00 GMT, Nir Lisker wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - ae9ee73e: Added @deprecated javadoc annotation and fixed ReadOnly variants > > Changes: > - all: https://git.openjdk.java.net/jfx/pull

Re: [Approved] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Kevin Rushforth
On Tue, 19 Nov 2019 19:17:00 GMT, Nir Lisker wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - ae9ee73e: Added @deprecated javadoc annotation and fixed ReadOnly variants > > Changes: > - all: https://git.openjdk.java.net/jfx/pull

Re: [Rev 02] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Nir Lisker
The pull request has been updated with additional changes. Added commits: - ae9ee73e: Added @deprecated javadoc annotation and fixed ReadOnly variants Changes: - all: https://git.openjdk.java.net/jfx/pull/30/files - new: https://git.openjdk.java.net/jfx/pull/30/files/a1cdb3

Re: RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Kevin Rushforth
On Tue, 19 Nov 2019 18:02:23 GMT, Nir Lisker wrote: > On Mon, 18 Nov 2019 18:12:13 GMT, Kevin Rushforth wrote: > >> On Wed, 13 Nov 2019 23:47:58 GMT, Kevin Rushforth wrote: >> >>> On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote: >>> On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker w

Re: RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-19 Thread Nir Lisker
On Mon, 18 Nov 2019 18:12:13 GMT, Kevin Rushforth wrote: > On Wed, 13 Nov 2019 23:47:58 GMT, Kevin Rushforth wrote: > >> On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote: >> >>> On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker wrote: >>> On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg

Re: RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-18 Thread Kevin Rushforth
On Wed, 13 Nov 2019 23:47:58 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote: > >> On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker wrote: >> >>> On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg >>> wrote: >>> On Wed, 6 Nov 2019 05:07:56 GMT, Kevin Rushf

Re: [Rev 01] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-18 Thread Ambarish Rapte
On Wed, 6 Nov 2019 14:28:20 GMT, Nir Lisker wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - a1cdb37b: Removed whitespaces in @Deprecated comments > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/30/files > - new: h

Re: RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-13 Thread Kevin Rushforth
On Wed, 6 Nov 2019 12:54:40 GMT, Kevin Rushforth wrote: > On Wed, 6 Nov 2019 11:50:27 GMT, Nir Lisker wrote: > >> On Wed, 6 Nov 2019 07:12:26 GMT, Robin Westberg >> wrote: >> >>> On Wed, 6 Nov 2019 05:07:56 GMT, Kevin Rushforth wrote: >>> On Wed, 6 Nov 2019 05:04:28 GMT, Kevin Rushfor

Re: [Approved] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-13 Thread Kevin Rushforth
On Wed, 6 Nov 2019 14:28:20 GMT, Nir Lisker wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - a1cdb37b: Removed whitespaces in @Deprecated comments > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/30/files > - new: h

Re: [Rev 01] RFR: 8229472: Deprecate for removal JavaBeanXxxPropertyBuilders constructors

2019-11-06 Thread Nir Lisker
The pull request has been updated with additional changes. Added commits: - a1cdb37b: Removed whitespaces in @Deprecated comments Changes: - all: https://git.openjdk.java.net/jfx/pull/30/files - new: https://git.openjdk.java.net/jfx/pull/30/files/6d29e034..a1cdb37b Webrevs