Re: [Integrated] RFR: 8232687: No static JNI loader for libprism-sw

2019-10-22 Thread Johan Vos
Changeset: 2ae171a2 Author:Johan Vos Date: 2019-10-22 11:44:12 + URL: https://git.openjdk.java.net/jfx/commit/2ae171a2 8232687: No static JNI loader for libprism-sw Reviewed-by: kcr ! buildSrc/mac.gradle ! modules/javafx.graphics/src/main/native-prism-sw/JNIUtil.c

Re: [Rev 01] RFR: 8232687: No static JNI loader for libprism-sw

2019-10-21 Thread Kevin Rushforth
On Mon, 21 Oct 2019 11:10:32 GMT, Johan Vos wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - f34a99a3: In order to leverage this on Mac, we need to add -DSTATIC_BUILD > to the cc flags > > Changes: > - all:

Re: [Approved] RFR: 8232687: No static JNI loader for libprism-sw

2019-10-21 Thread Kevin Rushforth
On Mon, 21 Oct 2019 10:03:24 GMT, Johan Vos wrote: > This PR adds a JNI_OnLoad_prism_sw call to the static lib libprism_sw.a. > This approach is similar to the addition of e.g. JNI_OnLoad_prism_es2 that > has been done as part of https://bugs.openjdk.java.net/browse/JDK-8223760 > > Unless

Re: [Rev 01] RFR: 8232687: No static JNI loader for libprism-sw

2019-10-21 Thread Johan Vos
The pull request has been updated with additional changes. Added commits: - f34a99a3: In order to leverage this on Mac, we need to add -DSTATIC_BUILD to the cc flags Changes: - all: https://git.openjdk.java.net/jfx/pull/19/files - new:

RFR: 8232687: No static JNI loader for libprism-sw

2019-10-21 Thread Johan Vos
This PR adds a JNI_OnLoad_prism_sw call to the static lib libprism_sw.a. This approach is similar to the addition of e.g. JNI_OnLoad_prism_es2 that has been done as part of https://bugs.openjdk.java.net/browse/JDK-8223760 Unless -PSTATIC_BUILD is provided when building, this patch has no