RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

2019-10-31 Thread Jeanette Winzenburg
https://bugs.openjdk.java.net/browse/JDK-8233040 The issue is that the eventFilter in CBPC uses F4 for toggling the popup _and_ consumes it. This prevents client code to register there own filter. The fix was to remove the block entirely - F4 is already handled by a keyMapping in ComboBoxBehav

Re: RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

2019-10-31 Thread Kevin Rushforth
On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg wrote: > https://bugs.openjdk.java.net/browse/JDK-8233040 > > The issue is that the eventFilter in CBPC uses F4 for toggling the popup > _and_ consumes it. This prevents client code to register there own filter. > > The fix was to remove

Re: RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

2019-11-04 Thread Ajit Ghaisas
On Thu, 31 Oct 2019 15:04:35 GMT, Jeanette Winzenburg wrote: > https://bugs.openjdk.java.net/browse/JDK-8233040 > > The issue is that the eventFilter in CBPC uses F4 for toggling the popup > _and_ consumes it. This prevents client code to register there own filter. > > The fix was to remove the

Re: [Integrated] RFR: 8233040: Fix: ComboBoxPopupControl - remove eventFilter for F4

2019-11-05 Thread Ajit Ghaisas
Changeset: f74f3afb Author:Jeanette Winzenburg Committer: Ajit Ghaisas Date: 2019-11-05 12:08:33 + URL: https://git.openjdk.java.net/jfx/commit/f74f3afb 8233040: ComboBoxPopupControl: remove eventFilter for F4 Reviewed-by: aghaisas ! modules/javafx.controls/src/main/java/ja