Re: [Integrated] RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-15 Thread Kevin Rushforth
Changeset: 927fc8a0 Author:Alexander Scherbatiy Committer: Kevin Rushforth Date: 2019-11-15 13:04:12 + URL: https://git.openjdk.java.net/jfx/commit/927fc8a0 8234174: Change IDEA VCS mapping to Git Reviewed-by: kcr ! .idea/vcs.xml

Re: [Approved] RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 15:30:09 GMT, Alexander Scherbatiy wrote: > The pull request has been updated with additional changes. > > > > Added commits: > - c55e4d81: Restore new line in the end of .idea/vcs.xml file > > Changes: > - all: https://git.openjdk.java.net/jfx/pull/37/

Re: [Rev 01] RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
The pull request has been updated with additional changes. Added commits: - c55e4d81: Restore new line in the end of .idea/vcs.xml file Changes: - all: https://git.openjdk.java.net/jfx/pull/37/files - new: https://git.openjdk.java.net/jfx/pull/37/files/f0f1866a..c55e4d81 W

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
On Thu, 14 Nov 2019 15:06:07 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy > wrote: > >> Allow IDEA to correctly detect Git version control system when opening JFX >> project. >> >> >> >> Commits: >> - f0f1866a: 8234174: Change IDEA V

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
On Thu, 14 Nov 2019 15:18:15 GMT, Alexander Scherbatiy wrote: > On Thu, 14 Nov 2019 15:06:07 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy >> wrote: >> >>> Allow IDEA to correctly detect Git version control system when opening JFX >>> project. >>>

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
On Thu, 14 Nov 2019 15:06:07 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy > wrote: > >> Allow IDEA to correctly detect Git version control system when opening JFX >> project. >> >> >> >> Commits: >> - f0f1866a: 8234174: Change IDEA V

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy wrote: > Allow IDEA to correctly detect Git version control system when opening JFX > project. > > > > Commits: > - f0f1866a: 8234174: Change IDEA VCS mapping to Git > > Changes: https://git.openjdk.java.net/jfx/pull/37

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Thiago Milczarek Sayao
On Thu, 14 Nov 2019 14:35:28 GMT, Alexander Scherbatiy wrote: > On Thu, 14 Nov 2019 14:35:27 GMT, Kevin Rushforth wrote: > >> On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy >> wrote: >> >>> Allow IDEA to correctly detect Git version control system when opening JFX >>> project. >>>

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
On Thu, 14 Nov 2019 14:35:27 GMT, Kevin Rushforth wrote: > On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy > wrote: > >> Allow IDEA to correctly detect Git version control system when opening JFX >> project. >> >> >> >> Commits: >> - f0f1866a: 8234174: Change IDEA V

RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Alexander Scherbatiy
Allow IDEA to correctly detect Git version control system when opening JFX project. Commits: - f0f1866a: 8234174: Change IDEA VCS mapping to Git Changes: https://git.openjdk.java.net/jfx/pull/37/files Webrev: https://webrevs.openjdk.java.net/jfx/37/webrev.00 Issue: https://

Re: RFR: 8234174: Change IDEA VCS mapping to Git

2019-11-14 Thread Kevin Rushforth
On Thu, 14 Nov 2019 14:35:26 GMT, Alexander Scherbatiy wrote: > Allow IDEA to correctly detect Git version control system when opening JFX > project. > > > > Commits: > - f0f1866a: 8234174: Change IDEA VCS mapping to Git > > Changes: https://git.openjdk.java.net/jfx/pull/37