Re: [Integrated] RFR: 8242001: ChoiceBox: must update value on setting SelectionModel, part2

2020-05-08 Thread Jeanette Winzenburg
On Tue, 5 May 2020 10:50:40 GMT, Jeanette Winzenburg wrote: > The issue is that ChoiceBox didn't sync its value to the replaced > SelectionModel's selectedItem if the item is null. > > Fixed by removing the constraint from selectionModel property. > > Added tests that failed before and

Re: RFR: 8242001: ChoiceBox: must update value on setting SelectionModel, part2

2020-05-08 Thread Ajit Ghaisas
On Tue, 5 May 2020 10:50:40 GMT, Jeanette Winzenburg wrote: > The issue is that ChoiceBox didn't sync its value to the replaced > SelectionModel's selectedItem if the item is null. > > Fixed by removing the constraint from selectionModel property. > > Added tests that failed before and

Re: RFR: 8242001: ChoiceBox: must update value on setting SelectionModel, part2

2020-05-06 Thread Kevin Rushforth
On Tue, 5 May 2020 10:50:40 GMT, Jeanette Winzenburg wrote: > The issue is that ChoiceBox didn't sync its value to the replaced > SelectionModel's selectedItem if the item is null. > > Fixed by removing the constraint from selectionModel property. > > Added tests that failed before and

RFR: 8242001: ChoiceBox: must update value on setting SelectionModel, part2

2020-05-05 Thread Jeanette Winzenburg
The issue is that ChoiceBox didn't sync its value to the replaced SelectionModel's selectedItem if the item is null. Fixed by removing the constraint from selectionModel property. Added tests that failed before and passed after the fix. Note that I also changed a test method in ChoiceBoxTest