Re: RFR: 8244234: MenuButton: NPE on removing from scene with open popup [v2]

2022-01-18 Thread Ajit Ghaisas
On Mon, 17 Jan 2022 15:32:13 GMT, eduardsdv wrote: >> The NPE occurs when the skinnable is removed from the scene while the popup >> is showing. >> The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics >> from the scene and runs into NPE. >> To avoid NPE a null-check is a

Re: RFR: 8244234: MenuButton: NPE on removing from scene with open popup [v2]

2022-01-17 Thread eduardsdv
> The NPE occurs when the skinnable is removed from the scene while the popup > is showing. > The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics > from the scene and runs into NPE. > To avoid NPE a null-check is added to the 'showing' listener. > > Since the mnemonics c

Re: RFR: 8244234: MenuButton: NPE on removing from scene with open popup

2022-01-17 Thread eduardsdv
On Tue, 11 Jan 2022 14:42:19 GMT, eduardsdv wrote: > The NPE occurs when the skinnable is removed from the scene while the popup > is showing. > The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics > from the scene and runs into NPE. > To avoid NPE a null-check is added

Re: RFR: 8244234: MenuButton: NPE on removing from scene with open popup

2022-01-17 Thread Ajit Ghaisas
On Tue, 11 Jan 2022 14:42:19 GMT, eduardsdv wrote: > The NPE occurs when the skinnable is removed from the scene while the popup > is showing. > The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics > from the scene and runs into NPE. > To avoid NPE a null-check is added

RFR: 8244234: MenuButton: NPE on removing from scene with open popup

2022-01-11 Thread eduardsdv
The NPE occurs when the skinnable is removed from the scene while the popup is showing. The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics from the scene and runs into NPE. To avoid NPE a null-check is added to the 'showing' listener. Since the mnemonics cannot be remov