Re: [Integrated] RFR: 8244417: support static build for Windows

2020-05-12 Thread Joeri Sykora
On Thu, 7 May 2020 21:15:02 GMT, Joeri Sykora wrote: > Adds support for building static libraries of the OpenJFX modules for the > Windows platform. Building static libraries > is done by providing the gradle property `-PSTATIC_BUILD=true`. > Changes include: > > - add static flags for the comp

Re: RFR: 8244417: support static build for Windows

2020-05-12 Thread Johan Vos
On Thu, 7 May 2020 21:15:02 GMT, Joeri Sykora wrote: > Adds support for building static libraries of the OpenJFX modules for the > Windows platform. Building static libraries > is done by providing the gradle property `-PSTATIC_BUILD=true`. > Changes include: > > - add static flags for the comp

Re: RFR: 8244417: support static build for Windows

2020-05-08 Thread Kevin Rushforth
On Thu, 7 May 2020 21:15:02 GMT, Joeri Sykora wrote: > Adds support for building static libraries of the OpenJFX modules for the > Windows platform. Building static libraries > is done by providing the gradle property `-PSTATIC_BUILD=true`. > Changes include: > > - add static flags for the comp

Re: RFR: 8244417: support static build for Windows

2020-05-08 Thread Joeri Sykora
On Fri, 8 May 2020 19:12:48 GMT, Kevin Rushforth wrote: >> modules/javafx.graphics/src/main/native-prism-d3d/D3DPipeline.cc line 39: >> >>> 38: >>> 39: static jboolean checkAndClearException(JNIEnv *env) { >>> 40: if (!env->ExceptionCheck()) { >> >> while this looks ok to me, I'm not sure w

Re: RFR: 8244417: support static build for Windows

2020-05-08 Thread Kevin Rushforth
On Fri, 8 May 2020 19:01:28 GMT, Johan Vos wrote: >> Adds support for building static libraries of the OpenJFX modules for the >> Windows platform. Building static libraries >> is done by providing the gradle property `-PSTATIC_BUILD=true`. >> Changes include: >> >> - add static flags for the c

Re: RFR: 8244417: support static build for Windows

2020-05-08 Thread Johan Vos
On Thu, 7 May 2020 21:15:02 GMT, Joeri Sykora wrote: > Adds support for building static libraries of the OpenJFX modules for the > Windows platform. Building static libraries > is done by providing the gradle property `-PSTATIC_BUILD=true`. > Changes include: > > - add static flags for the comp

RFR: 8244417: support static build for Windows

2020-05-08 Thread Joeri Sykora
Adds support for building static libraries of the OpenJFX modules for the Windows platform. Building static libraries is done by providing the gradle property `-PSTATIC_BUILD=true`. Changes include: - add static flags for the compiler and linker - use `lib` for linking instead of `link` - only b