Re: [Integrated] RFR: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

2020-05-30 Thread Jeanette Winzenburg
On Tue, 26 May 2020 13:41:15 GMT, Jeanette Winzenburg wrote: > Both skins have similar misbehavior when switching skins > > - memory leak due to a manually added but not removed change listener > - NPE when modifying items after skin switch due to a not removed listener to > the control's

Re: RFR: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

2020-05-28 Thread Ajit Ghaisas
On Tue, 26 May 2020 13:41:15 GMT, Jeanette Winzenburg wrote: > Both skins have similar misbehavior when switching skins > > - memory leak due to a manually added but not removed change listener > - NPE when modifying items after skin switch due to a not removed listener to > the control's

RFR: 8244657: ChoiceBox/ToolBarSkin: misbehavior on switching skin

2020-05-26 Thread Jeanette Winzenburg
Both skins have similar misbehavior when switching skins - memory leak due to a manually added but not removed change listener - NPE when modifying items after skin switch due to a not removed listener to the control's items Fixed in both (for details see the issue). Added SkinCleanupTest for