Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v6]

2020-07-29 Thread Johan Vos
On Thu, 25 Jun 2020 18:20:55 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v6]

2020-06-25 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v5]

2020-06-25 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus [v4]

2020-06-24 Thread Johan Vos
On Fri, 12 Jun 2020 13:38:10 GMT, Abhinay Agarwal wrote: >> worth discussing the case were a TextInput is the only control. > > @mipastgt The issue happens because of the focus listener. With this PR, we > introduce `mouseEventListener` to show the > Keyboard on `MOUSE_CLICKED` event. Therefore

Re: [Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-06-12 Thread Abhinay Agarwal
On Fri, 29 May 2020 16:48:29 GMT, Johan Vos wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix typo: dispose should remove event handler > > worth discussing the case were a TextInput is the only control. @mip

Re: [Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Johan Vos
On Fri, 29 May 2020 15:09:30 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This

Re: [Rev 03] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Michael Paus
On Fri, 29 May 2020 12:48:29 GMT, Johan Vos wrote: >> Abhinay Agarwal has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Skin implementation must maintain the contract of dispose > > Looks good. > A test strategy for Android is a good idea

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-29 Thread Johan Vos
On Tue, 19 May 2020 10:19:42 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
On Tue, 19 May 2020 09:23:38 GMT, Jeanette Winzenburg wrote: >> @kleopatra Done! > > wondering if there is any way to include android specific skins in unit > testing? For all (nearly, htmlEditor excluded > ;) others we have a test to guard against contract violations (and will soon > have tes

Re: [Rev 02] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Jeanette Winzenburg
On Tue, 19 May 2020 08:08:44 GMT, Abhinay Agarwal wrote: >> out off my home-zone here, just fyi and in case it might be relevant to >> android skins as well: there's an umbrella >> issue to cleanup skin implementations >> [JDK-8241364](https://bugs.openjdk.java.net/browse/JDK-8241364) - both t

Re: [Rev 01] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Jeanette Winzenburg
On Tue, 19 May 2020 08:10:40 GMT, Abhinay Agarwal wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard. This

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
On Fri, 15 May 2020 10:58:14 GMT, Jeanette Winzenburg wrote: >> In Android, TextInputControls (TextField and TextArea) are responsible for >> showing and hiding software keyboard. >> Currently, a focus listener is attached to these controls and is used to >> toggle the visibility of keyboard.

Re: [Rev 01] RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-19 Thread Abhinay Agarwal
> In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > condition fails in cases where the control already has focus

Re: RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-15 Thread Jeanette Winzenburg
On Thu, 14 May 2020 19:22:54 GMT, Abhinay Agarwal wrote: > In Android, TextInputControls (TextField and TextArea) are responsible for > showing and hiding software keyboard. > Currently, a focus listener is attached to these controls and is used to > toggle the visibility of keyboard. This > c

RFR: 8245053: Keyboard doesn't show when TextInputControl has focus

2020-05-14 Thread Abhinay Agarwal
In Android, TextInputControls (TextField and TextArea) are responsible for showing and hiding software keyboard. Currently, a focus listener is attached to these controls and is used to toggle the visibility of keyboard. This condition fails in cases where the control already has focus but the ke