Re: [Integrated] RFR: 8246357: Allow static build of webkit library on linux

2020-06-09 Thread Johan Vos
On Tue, 2 Jun 2020 17:52:37 GMT, Johan Vos wrote: > add changes to build a static version of libjfxwebkit.a > Fox for JDK-8246357 This pull request has now been integrated. Changeset: ba501ef2 Author:Johan Vos URL: https://git.openjdk.java.net/jfx/commit/ba501ef2 Stats: 20 lines

Re: RFR: 8246357: Allow static build of webkit library on linux

2020-06-03 Thread Arun Joseph
On Tue, 2 Jun 2020 17:52:37 GMT, Johan Vos wrote: > add changes to build a static version of libjfxwebkit.a > Fox for JDK-8246357 Changes looks good to me. - Marked as reviewed by ajoseph (Committer). PR: https://git.openjdk.java.net/jfx/pull/245

Re: RFR: 8246357: Allow static build of webkit library on linux

2020-06-03 Thread Kevin Rushforth
On Tue, 2 Jun 2020 17:52:37 GMT, Johan Vos wrote: > add changes to build a static version of libjfxwebkit.a > Fox for JDK-8246357 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/245

Re: RFR: 8246357: Allow static build of webkit library on linux

2020-06-03 Thread Kevin Rushforth
On Tue, 2 Jun 2020 18:01:40 GMT, Kevin Rushforth wrote: >> add changes to build a static version of libjfxwebkit.a >> Fox for JDK-8246357 > > @arun-Joseph @guruhb can one of you also review? The diffs look good. I'm doing test builds now. - PR:

Re: RFR: 8246357: Allow static build of webkit library on linux

2020-06-02 Thread Kevin Rushforth
On Tue, 2 Jun 2020 17:52:37 GMT, Johan Vos wrote: > add changes to build a static version of libjfxwebkit.a > Fox for JDK-8246357 @arun-Joseph @guruhb can one of you also review? - PR: https://git.openjdk.java.net/jfx/pull/245

RFR: 8246357: Allow static build of webkit library on linux

2020-06-02 Thread Johan Vos
add changes to build a static version of libjfxwebkit.a Fox for JDK-8246357 - Commit messages: - add changes to build a static version of libjfxwebkit.a Changes: https://git.openjdk.java.net/jfx/pull/245/files Webrev: https://webrevs.openjdk.java.net/jfx/245/webrev.00 Issue: