Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v2]

2020-08-13 Thread Kevin Rushforth
On Thu, 13 Aug 2020 18:11:25 GMT, Kevin Rushforth wrote: >> Thank you for the very quick feedback! >> In the application, the fix was developed for, it also seems to fix all >> issues related to iconified. > > You may have seen my comment in JBS: This PR also fixes >

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v2]

2020-08-13 Thread Kevin Rushforth
On Thu, 13 Aug 2020 17:09:43 GMT, Florian Kirmaier wrote: >> This looks good based on my initial testing, including a modified version of >> the test program that doesn't temporarily >> set resizable to true. Nice. >> I want to do some additional testing. >> >> I left one minor comment on the

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v2]

2020-08-13 Thread Florian Kirmaier
On Thu, 13 Aug 2020 16:35:51 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8251241 >> Added missing spaces to match the coding style. > >

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v2]

2020-08-13 Thread Florian Kirmaier
On Thu, 13 Aug 2020 16:37:44 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8251241 >> Added missing spaces to match the coding style. > > This looks good based on my initial

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v2]

2020-08-13 Thread Florian Kirmaier
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241 > > This small change fixing the minimize for mac. > Changes are property registered. > Calling setIconize(true) no longer resets to false. Florian Kirmaier has updated the pull request incrementally with one additional commit since the