Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v3]

2020-08-19 Thread Ambarish Rapte
On Thu, 13 Aug 2020 19:45:49 GMT, Florian Kirmaier wrote: >> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241 >> >> This small change fixing the minimize for mac. >> Changes are property registered. >> Calling setIconize(true) no longer resets to false. > > Florian Kirmaier has updated

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v3]

2020-08-19 Thread Kevin Rushforth
On Thu, 13 Aug 2020 20:29:47 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8251241 >> applied tests from kevinrushforth > > Looks good. Thanks for fixing this long-standing bug. > > I

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v3]

2020-08-13 Thread Kevin Rushforth
On Thu, 13 Aug 2020 19:45:49 GMT, Florian Kirmaier wrote: >> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241 >> >> This small change fixing the minimize for mac. >> Changes are property registered. >> Calling setIconize(true) no longer resets to false. > > Florian Kirmaier has updated

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v3]

2020-08-13 Thread Florian Kirmaier
> ticket: https://bugs.openjdk.java.net/browse/JDK-8251241 > > This small change fixing the minimize for mac. > Changes are property registered. > Calling setIconize(true) no longer resets to false. Florian Kirmaier has updated the pull request incrementally with one additional commit since the

Re: RFR: 8251241: macOS: iconify property doesn't change after minimize when resizable is false [v3]

2020-08-13 Thread Florian Kirmaier
On Thu, 13 Aug 2020 19:21:56 GMT, Kevin Rushforth wrote: >> You may have seen my comment in JBS: This PR also fixes >> [JDK-8249202](https://bugs.openjdk.java.net/browse/JDK-8249202), which I >> discovered while testing >> [JDK-8248490](https://bugs.openjdk.java.net/browse/JDK-8248490). This