On Tue, 1 Feb 2022 17:41:47 GMT, Marius Hanl wrote:
>> This PR will fix a simple NPE which may happens when using the `TableRow`
>> inside a `TableCell` during the initial auto sizing.
>> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()`
>> will return null and it is not
On Sat, 29 Jan 2022 13:57:01 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8251481: Using global stageLoader now
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTa
> This PR will fix a simple NPE which may happens when using the `TableRow`
> inside a `TableCell` during the initial auto sizing.
> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will
> return null and it is not possible to e.g. access the row item.
>
> This is fixed b
On Thu, 27 Jan 2022 20:38:56 GMT, Marius Hanl wrote:
>> This PR will fix a simple NPE which may happens when using the `TableRow`
>> inside a `TableCell` during the initial auto sizing.
>> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()`
>> will return null and it is not
On Fri, 28 Jan 2022 13:14:37 GMT, Marius Hanl wrote:
>> just curious: why didn't you move the tests into TableColumnHeaderTest?
>
> I had no particular reason, I think the test fits both classes, although
> `TableColumnHeaderTest` just tests the normal `TableView`. So I kept it in
> the `TableC
On Fri, 28 Jan 2022 12:40:15 GMT, Jeanette Winzenburg
wrote:
>> I can align it. And yeah makes sense to add a test for the
>> TreeTableView/TreeTableCell.
>
> just curious: why didn't you move the tests into TableColumnHeaderTest?
I had no particular reason, I think the test fits both classes,
On Thu, 27 Jan 2022 10:21:18 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableCellTest.java
>> line 371:
>>
>>> 369: @Test
>>> 370: public void testRowIsNotNullWhenAutoSizing() {
>>> 371: TableColumn tableColumn = new TableColumn<>(
On Tue, 25 Jan 2022 12:09:31 GMT, Jeanette Winzenburg
wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8251481: Using global stageLoader now
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableC
> This PR will fix a simple NPE which may happens when using the `TableRow`
> inside a `TableCell` during the initial auto sizing.
> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will
> return null and it is not possible to e.g. access the row item.
>
> This is fixed b
> This PR will fix a simple NPE which may happens when using the `TableRow`
> inside a `TableCell` during the initial auto sizing.
> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will
> return null and it is not possible to e.g. access the row item.
>
> This is fixed b
On Tue, 25 Jan 2022 12:00:11 GMT, Jeanette Winzenburg
wrote:
>> This PR will fix a simple NPE which may happens when using the `TableRow`
>> inside a `TableCell` during the initial auto sizing.
>> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()`
>> will return null and
On Fri, 14 Jan 2022 00:04:49 GMT, Marius Hanl wrote:
> This PR will fix a simple NPE which may happens when using the `TableRow`
> inside a `TableCell` during the initial auto sizing.
> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will
> return null and it is not pos
On Fri, 14 Jan 2022 11:52:40 GMT, Jeanette Winzenburg
wrote:
> hmm .. I think here are two issues:
>
> * the auto-sizing code definitely needs to fully configure the cell (with
> index, row, column, tableView plus applying css) to measure the correct size
> * the implementation of cell.updateI
On Fri, 14 Jan 2022 00:04:49 GMT, Marius Hanl wrote:
> This PR will fix a simple NPE which may happens when using the `TableRow`
> inside a `TableCell` during the initial auto sizing.
> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will
> return null and it is not pos
This PR will fix a simple NPE which may happens when using the `TableRow`
inside a `TableCell` during the initial auto sizing.
In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will
return null and it is not possible to e.g. access the row item.
This is fixed by adding the
15 matches
Mail list logo
