Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-06 Thread Johan Vos
On Thu, 5 Nov 2020 20:57:13 GMT, John Neffenger wrote: >> Marked as reviewed by kcr (Lead). > > Thanks, Johan. Can we compare build environments? I cross-compile on Ubuntu > 20.04.1 LTS. I followed the instructions at [Cross Building for ARM Hard > Float][1] to fetch the toolchain. I use

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread John Neffenger
On Thu, 5 Nov 2020 20:33:05 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change invocation of getEGLDisplayHandle into getEglDisplayHandle >> Conditionally add dlfcn > > Marked as reviewed

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Kevin Rushforth
On Thu, 5 Nov 2020 16:41:09 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 19:27:54 GMT, John Neffenger wrote: >> Marked as reviewed by jpereda (Committer). > > The fix for the compile-time error still fails for target *armv6hf*: > `MonocleGLFactory.c:110:19: error: ‘RTLD_DEFAULT’ undeclared (first use in > this function)`. Here's one solution: >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread John Neffenger
On Thu, 5 Nov 2020 18:16:58 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change invocation of getEGLDisplayHandle into getEglDisplayHandle >> Conditionally add dlfcn > > Marked as reviewed by

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Jose Pereda
On Thu, 5 Nov 2020 16:41:09 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v6]

2020-11-05 Thread Johan Vos
> Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any low-level system. Johan Vos has updated the pull

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v5]

2020-11-05 Thread Kevin Rushforth
On Thu, 5 Nov 2020 13:38:08 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-05 Thread Kevin Rushforth
On Thu, 5 Nov 2020 13:34:40 GMT, Johan Vos wrote: >> modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/EGLAcceleratedScreen.java >> line 46: >> >>> 44: */ >>> 45: EGLAcceleratedScreen(int[] attributes) throws GLException { >>> 46: eglWindowHandle =

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 02:48:17 GMT, John Neffenger wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add one more @override to process reviewer comments > >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 02:45:00 GMT, John Neffenger wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add one more @override to process reviewer comments > >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v5]

2020-11-05 Thread Johan Vos
> Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any low-level system. Johan Vos has updated the pull

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-05 Thread Johan Vos
On Thu, 5 Nov 2020 02:44:01 GMT, John Neffenger wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> add one more @override to process reviewer comments > >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-04 Thread John Neffenger
On Wed, 4 Nov 2020 16:14:06 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-04 Thread Kevin Rushforth
On Wed, 4 Nov 2020 16:14:06 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v2]

2020-11-04 Thread Johan Vos
On Wed, 4 Nov 2020 15:55:46 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/EGLAcceleratedScreen.java >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-04 Thread Johan Vos
> Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any low-level system. Johan Vos has updated the pull

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v4]

2020-11-04 Thread Jose Pereda
On Wed, 4 Nov 2020 16:11:21 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v2]

2020-11-04 Thread Jose Pereda
On Wed, 4 Nov 2020 11:12:06 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v2]

2020-11-04 Thread Johan Vos
On Wed, 4 Nov 2020 15:56:44 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewer comments > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/EGLAcceleratedScreen.java >

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v3]

2020-11-04 Thread Johan Vos
> Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any low-level system. Johan Vos has updated the pull

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v2]

2020-11-04 Thread Jose Pereda
On Wed, 4 Nov 2020 11:12:06 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v2]

2020-11-04 Thread Kevin Rushforth
On Wed, 4 Nov 2020 11:12:06 GMT, Johan Vos wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >> to

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v2]

2020-11-04 Thread Johan Vos
> Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any low-level system. Johan Vos has updated the pull

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering [v2]

2020-11-04 Thread Johan Vos
On Tue, 3 Nov 2020 21:20:49 GMT, Kevin Rushforth wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewer comments > > modules/javafx.graphics/src/main/native-glass/monocle/egl/eglBridge.c line 56: > >> 54:

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering

2020-11-04 Thread Johan Vos
On Tue, 3 Nov 2020 21:15:34 GMT, Kevin Rushforth wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >>

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering

2020-11-04 Thread Johan Vos
On Tue, 3 Nov 2020 21:17:57 GMT, Kevin Rushforth wrote: >> Allow the EGL functionality in monocle to leverage EGL-based systems. The >> low-level specific details about how the EGL calls should be constructed are >> left out, and a native interface (egl_ext.h) is created that can be mapped >>

Re: RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering

2020-11-03 Thread Kevin Rushforth
On Fri, 30 Oct 2020 15:09:49 GMT, Johan Vos wrote: > Allow the EGL functionality in monocle to leverage EGL-based systems. The > low-level specific details about how the EGL calls should be constructed are > left out, and a native interface (egl_ext.h) is created that can be mapped to > any

RFR: 8254569: Remove hard dependency on Dispman in Monocle fb rendering

2020-10-30 Thread Johan Vos
Allow the EGL functionality in monocle to leverage EGL-based systems. The low-level specific details about how the EGL calls should be constructed are left out, and a native interface (egl_ext.h) is created that can be mapped to any low-level system. - Commit messages: - use a