Re: RFR: 8255415: Nested calls to snap methods in Region give different results [v5]

2020-11-02 Thread Ambarish Rapte
On Mon, 2 Nov 2020 13:07:11 GMT, Johan Vos wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Apply fix to snapPortionXX methods, extend test. > > Looks good now. Please go ahead and integrate with the current

Re: RFR: 8255415: Nested calls to snap methods in Region give different results [v5]

2020-11-02 Thread Johan Vos
On Tue, 27 Oct 2020 12:56:28 GMT, Jose Pereda wrote: >> As discussed in the [JBS >> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an >> already snapped value (either intentionally or by mistake), the result >> should be the same, otherwise we'll be jumping

Re: RFR: 8255415: Nested calls to snap methods in Region give different results [v5]

2020-11-02 Thread Jeanette Winzenburg
On Tue, 27 Oct 2020 12:56:28 GMT, Jose Pereda wrote: >> As discussed in the [JBS >> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an >> already snapped value (either intentionally or by mistake), the result >> should be the same, otherwise we'll be jumping

Re: RFR: 8255415: Nested calls to snap methods in Region give different results [v5]

2020-10-27 Thread Kevin Rushforth
On Tue, 27 Oct 2020 12:56:28 GMT, Jose Pereda wrote: >> As discussed in the [JBS >> issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an >> already snapped value (either intentionally or by mistake), the result >> should be the same, otherwise we'll be jumping

Re: RFR: 8255415: Nested calls to snap methods in Region give different results [v5]

2020-10-27 Thread Jose Pereda
> As discussed in the [JBS > issue](https://bugs.openjdk.java.net/browse/JDK-8199592), when snapping an > already snapped value (either intentionally or by mistake), the result > should be the same, otherwise we'll be jumping unnecessary from a valid pixel > to another pixel. > > This PR