Re: RFR: 8256012: Fix build of Monocle for Linux

2020-12-11 Thread Johan Vos
On Sat, 7 Nov 2020 23:13:48 GMT, John Neffenger wrote: > This pull request fixes the error when building embedded JavaFX for Linux. > > The error occurs because `MonocleGLFactory.c` does not define the macro > `__USE_GNU` before including the header file `dlfcn.h`. The two lines in the >

Re: RFR: 8256012: Fix build of Monocle for Linux [v3]

2020-12-11 Thread Johan Vos
On Fri, 11 Dec 2020 20:48:11 GMT, John Neffenger wrote: >> This pull request fixes the error when building embedded JavaFX for Linux. >> >> The error occurs because `MonocleGLFactory.c` does not define the macro >> `__USE_GNU` before including the header file `dlfcn.h`. The two lines in the

Re: RFR: 8256012: Fix build of Monocle for Linux [v3]

2020-12-11 Thread John Neffenger
> This pull request fixes the error when building embedded JavaFX for Linux. > > The error occurs because `MonocleGLFactory.c` does not define the macro > `__USE_GNU` before including the header file `dlfcn.h`. The two lines in the > conditional group "`#ifndef ANDROID`" below have no effect

Re: RFR: 8256012: Fix build of Monocle for Linux [v2]

2020-12-11 Thread John Neffenger
> This pull request fixes the error when building embedded JavaFX for Linux. > > The error occurs because `MonocleGLFactory.c` does not define the macro > `__USE_GNU` before including the header file `dlfcn.h`. The two lines in the > conditional group "`#ifndef ANDROID`" below have no effect

Re: RFR: 8256012: Fix build of Monocle for Linux

2020-11-27 Thread Johan Vos
On Thu, 26 Nov 2020 19:32:28 GMT, John Neffenger wrote: >> I don't see any harm in this PR, but I wonder which toolchains are still not >> having `RTLD_NEXT` without specifying GNU_SOURCE. Does it also work if you >> specify `-D__USE_GNU` to the compiler? > >> I don't see any harm in this

Re: RFR: 8256012: Fix build of Monocle for Linux

2020-11-26 Thread John Neffenger
On Tue, 24 Nov 2020 21:18:03 GMT, Johan Vos wrote: > I don't see any harm in this PR, but I wonder which toolchains are still not > having `RTLD_NEXT` without specifying GNU_SOURCE. Thanks, Johan. I've been following the instructions in the [OpenJFX Wiki][1]. I use the GCC cross-compiler

Re: RFR: 8256012: Fix build of Monocle for Linux

2020-11-24 Thread Johan Vos
On Sat, 7 Nov 2020 23:13:48 GMT, John Neffenger wrote: > This pull request fixes the error when building embedded JavaFX for Linux. > > The error occurs because `MonocleGLFactory.c` does not define the macro > `__USE_GNU` before including the header file `dlfcn.h`. The two lines in the >

RFR: 8256012: Fix build of Monocle for Linux

2020-11-07 Thread John Neffenger
This pull request fixes the error when building embedded JavaFX for Linux. The error occurs because `MonocleGLFactory.c` does not define the macro `__USE_GNU` before including the header file `dlfcn.h`. The two lines in the conditional group "`#ifndef ANDROID`" below have no effect because the