Re: RFR: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin [v3]

2020-12-07 Thread Ambarish Rapte
On Mon, 7 Dec 2020 10:46:32 GMT, Jeanette Winzenburg wrote: >> issues with behavior: >> - memory leak due to an key eventHandler that's not removed >> - after dispose, still modifying treeView (anchor) state due to listeners >> selection that are not removed >> >> issues with skin: >> - memory

Re: RFR: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin [v3]

2020-12-07 Thread Jeanette Winzenburg
> issues with behavior: > - memory leak due to an key eventHandler that's not removed > - after dispose, still modifying treeView (anchor) state due to listeners > selection that are not removed > > issues with skin: > - memory leak due to behavior leaking > - memory leak due to cellFactory in fl

Re: RFR: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin [v2]

2020-12-07 Thread Jeanette Winzenburg
On Mon, 7 Dec 2020 09:29:32 GMT, Ambarish Rapte wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed c&p naming error > > modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinCleanupTest

Re: RFR: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin [v2]

2020-12-07 Thread Jeanette Winzenburg
> issues with behavior: > - memory leak due to an key eventHandler that's not removed > - after dispose, still modifying treeView (anchor) state due to listeners > selection that are not removed > > issues with skin: > - memory leak due to behavior leaking > - memory leak due to cellFactory in fl

Re: RFR: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin

2020-12-07 Thread Ambarish Rapte
On Tue, 24 Nov 2020 14:17:21 GMT, Jeanette Winzenburg wrote: > issues with behavior: > - memory leak due to an key eventHandler that's not removed > - after dispose, still modifying treeView (anchor) state due to listeners > selection that are not removed > > issues with skin: > - memory leak

RFR: 8256821: TreeViewSkin/Behavior: misbehavior on switching skin

2020-11-24 Thread Jeanette Winzenburg
issues with behavior: - memory leak due to an key eventHandler that's not removed - after dispose, still modifying treeView (anchor) state due to listeners selection that are not removed issues with skin: - memory leak due to behavior leaking - memory leak due to cellFactory in flow not removed -