Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
-
Commit messages:
- 8259635: Update to 610.2 version of WebKit
Changes: https://git.openjdk.java.net/jfx/pull/382/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx&pr=382&range=00
Issue: https://bugs.openjdk.java.net/browse/
On Thu, 21 Jan 2021 04:14:28 GMT, Arun Joseph wrote:
> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
I reviewed all of the changes outside `modules/javafx.web/src/main/native/`.
Most look related to the change to use the Prism Color object instead of an
int. I did have a question about one o
On Thu, 21 Jan 2021 13:25:39 GMT, Kevin Rushforth wrote:
>> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
>
> I reviewed all of the changes outside `modules/javafx.web/src/main/native/`.
> Most look related to the change to use the Prism Color object instead of an
> int. I did have a question
On Thu, 21 Jan 2021 14:05:54 GMT, Arun Joseph wrote:
>> I reviewed all of the changes outside `modules/javafx.web/src/main/native/`.
>> Most look related to the change to use the Prism Color object instead of an
>> int. I did have a question about one of those changes:
>>
>> modules/javafx.web
> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
Arun Joseph has updated the pull request incrementally with one additional
commit since the last revision:
Fix color in DefaultPlugin
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/382/files
- new: https://git.openjdk
On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote:
>> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
>
> Arun Joseph has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix color in DefaultPlugin
Looks good. Build + automated tests passed o
On Thu, 21 Jan 2021 19:11:21 GMT, Kevin Rushforth wrote:
>> Arun Joseph has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix color in DefaultPlugin
>
> Looks good. Build + automated tests passed on all three platforms. I ran into
> one m
On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote:
>> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
>
> Arun Joseph has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix color in DefaultPlugin
Changes looks good to me. Did a local build
On Thu, 21 Jan 2021 15:57:04 GMT, Arun Joseph wrote:
>> Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
>
> Arun Joseph has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix color in DefaultPlugin
Marked as reviewed by jvos (Reviewer).
