[jfx11u] RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-05-08 Thread Kevin Rushforth
Clean backport to jfx11u. Tested on all three platforms, along with my other in-progress backports, all of which are aggregated in my [`kevinrushforth:test-kcr-11.0.12`](https://github.com/kevinrushforth/jfx11u/commits/test-kcr-11.0.12) branch. - Commit messages: - 8263788: JavaFX

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-20 Thread Guru Hb
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. Looks good to me . Tested on Windows with Modified WebView which loads multiple UR

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-20 Thread Kevin Rushforth
On Tue, 20 Apr 2021 10:31:59 GMT, PrimosK wrote: >> Issue: Java application (with WebView) will completely freeze after using it >> for a while. >> >> Fix: Use native isMainThread functions instead of JNI call. > > We've created another production build and it seems to be working fine! > Appl

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-20 Thread PrimosK
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. We've created another production build and it seems to be working fine! Applicatio

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-19 Thread PrimosK
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. Please discard my previous comment. After building a debug version we can't repro

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-19 Thread PrimosK
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. A production build using this fix doesn't solve it. Application still freezes. We

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-16 Thread Kevin Rushforth
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. Tested on all three platforms. Looks good. - Marked as reviewed by kc

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-16 Thread Kevin Rushforth
On Fri, 16 Apr 2021 08:49:19 GMT, Arun Joseph wrote: >> modules/javafx.web/src/main/native/Source/WTF/wtf/java/MainThreadJava.cpp >> line 45: >> >>> 43: #elif OS(WINDOWS) >>> 44: static ThreadIdentifier mainThread { 0 }; >>> 45: #endif >> >> Both here and below, where the `isMainThread` is def

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-16 Thread Kevin Rushforth
On Fri, 16 Apr 2021 14:10:48 GMT, Kevin Rushforth wrote: > A non-debug build crashes for me on startup in the > `com.sun.webkit.WebPage.twkCreatePage` method on both Windows and Mac. Never mind. This was a build error on my part. I've correct my mistake and will rerun the test. Sorry for the n

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-16 Thread Kevin Rushforth
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. A non-debug build crashes for me on startup in the `com.sun.webkit.WebPage.twkCrea

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-16 Thread Arun Joseph
On Thu, 15 Apr 2021 23:41:02 GMT, Kevin Rushforth wrote: >> Issue: Java application (with WebView) will completely freeze after using it >> for a while. >> >> Fix: Use native isMainThread functions instead of JNI call. > > modules/javafx.web/src/main/native/Source/WTF/wtf/java/MainThreadJava.cp

Re: RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-15 Thread Kevin Rushforth
On Mon, 12 Apr 2021 13:10:53 GMT, Arun Joseph wrote: > Issue: Java application (with WebView) will completely freeze after using it > for a while. > > Fix: Use native isMainThread functions instead of JNI call. The code changes look good. I still need to test it. Speaking of which, I presume

RFR: 8263788: JavaFX application freezes completely after some time when using the WebView

2021-04-15 Thread Arun Joseph
Issue: Java application (with WebView) will completely freeze after using it for a while. Fix: Use native isMainThread functions instead of JNI call. - Commit messages: - Remove platform check in ThreadingWin - Remove fwkIsMainThread - 8263788: JavaFX application freezes complete