Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-10-07 Thread Christian Stein
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote: >> https://bugs.openjdk.java.net/browse/JDK-8267472 > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Add module version to `graphics` and `web` project's compiler a

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-08-24 Thread Kevin Rushforth
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote: >> https://bugs.openjdk.java.net/browse/JDK-8267472 > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Add module version to `graphics` and `web` project's compiler a

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-08-24 Thread Johan Vos
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote: >> https://bugs.openjdk.java.net/browse/JDK-8267472 > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Add module version to `graphics` and `web` project's compiler a

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-08-23 Thread Christian Stein
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote: >> https://bugs.openjdk.java.net/browse/JDK-8267472 > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Add module version to `graphics` and `web` project's compiler a

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-08-23 Thread Christian Stein
On Mon, 23 Aug 2021 18:40:55 GMT, Johan Vos wrote: >> OK, that seems reasonable, and I can't think of any downside. > > The only thing that makes me slightly nervous is seeing that this is needed > on a number of places, leading to more code duplication (and the build.gradle > is already rather

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-08-23 Thread Kevin Rushforth
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote: >> https://bugs.openjdk.java.net/browse/JDK-8267472 > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Add module version to `graphics` and `web` project's compiler a

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-08-23 Thread Johan Vos
On Mon, 23 Aug 2021 16:43:34 GMT, Kevin Rushforth wrote: >> Seeing version information in stack traces of failed tests can be helpful. >> ;-) > > OK, that seems reasonable, and I can't think of any downside. The only thing that makes me slightly nervous is seeing that this is needed on a numbe

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-08-23 Thread Christian Stein
On Mon, 23 Aug 2021 18:18:51 GMT, Christian Stein wrote: >> https://bugs.openjdk.java.net/browse/JDK-8267472 > > Christian Stein has updated the pull request incrementally with one > additional commit since the last revision: > > Add module version to `graphics` and `web` project's compiler a

Re: RFR: 8267472: JavaFX modules to include version information [v3]

2021-08-23 Thread Christian Stein
> https://bugs.openjdk.java.net/browse/JDK-8267472 Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Add module version to `graphics` and `web` project's compiler args - Changes: - all: https://git.openjdk.java.net/jf