Re: [jfx17u] RFR: 8268849: Update to 612.1 version of WebKit

2021-09-15 Thread Kevin Rushforth
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. Thanks for the review and the sanity check. > There are only differences of copyright year. jfx17 files

Re: [jfx17u] RFR: 8268849: Update to 612.1 version of WebKit

2021-09-15 Thread Ambarish Rapte
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. Marked as reviewed by arapte (Reviewer). If we compare modules/javafx.web/src/main/native/Source of thi

Re: [jfx17u] RFR: 8268849: Update to 612.1 version of WebKit

2021-09-15 Thread Kevin Rushforth
On Mon, 13 Sep 2021 19:53:47 GMT, Kevin Rushforth wrote: > Clean backport to `jfx17u`. This has been tested on all platforms along with > other pending fixes in the `test-kcr-17.0.1` branch. For some reason, Skara didn't mark this as clean, so it needs a (sanity) review. @arapte Can you review

[jfx17u] RFR: 8268849: Update to 612.1 version of WebKit

2021-09-13 Thread Kevin Rushforth
Clean backport to `jfx17u`. This has been tested on all platforms along with other pending fixes in the `test-kcr-17.0.1` branch. - Commit messages: - 8268849: Update to 612.1 version of WebKit Changes: https://git.openjdk.java.net/jfx17u/pull/3/files Webrev: https://webrevs.openj

Re: [jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-18 Thread Ambarish Rapte
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote: > Nearly clean backport of third-party update to WebKit 612.1. There was one > minor conflict in one unit test file due to difference in context. > > As an FYI, I tested this patch in my > [test-kcr-11.0.13](https://github.com/kevinrushf

Re: [jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-17 Thread Johan Vos
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote: > Nearly clean backport of third-party update to WebKit 612.1. There was one > minor conflict in one unit test file due to difference in context. > > As an FYI, I tested this patch in my > [test-kcr-11.0.13](https://github.com/kevinrushf

Re: [jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-17 Thread Kevin Rushforth
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote: > Nearly clean backport of third-party update to WebKit 612.1. There was one > minor conflict in one unit test file due to difference in context. > > As an FYI, I tested this patch in my > [test-kcr-11.0.13](https://github.com/kevinrushf

Re: [jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-17 Thread Kevin Rushforth
On Tue, 17 Aug 2021 17:33:13 GMT, Kevin Rushforth wrote: > Nearly clean backport of third-party update to WebKit 612.1. There was one > minor conflict in one unit test file due to difference in context. > > As an FYI, I tested this patch in my > [test-kcr-11.0.13](https://github.com/kevinrushf

[jfx11u] RFR: 8268849: Update to 612.1 version of WebKit

2021-08-17 Thread Kevin Rushforth
Nearly clean backport of third-party update to WebKit 612.1. There was one minor conflict in one unit test file due to difference in context. As an FYI, I tested this patch in my [test-kcr-11.0.13](https://github.com/kevinrushforth/jfx11u/tree/test-kcr-11.0.13) branch, which has the aggregate s

Re: RFR: 8268849: Update to 612.1 version of WebKit [v2]

2021-07-14 Thread Johan Vos
On Tue, 6 Jul 2021 10:39:40 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.32 (612.1). >> There are two separate commits: >> 1. >> [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc) >> : includes only native changes >> 2. >> [commit](ht

Re: RFR: 8268849: Update to 612.1 version of WebKit [v2]

2021-07-06 Thread Kevin Rushforth
On Tue, 6 Jul 2021 10:39:40 GMT, Ambarish Rapte wrote: >> Update JavaFX WebKit to GTK WebKit 2.32 (612.1). >> There are two separate commits: >> 1. >> [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc) >> : includes only native changes >> 2. >> [commit](ht

Re: RFR: 8268849: Update to 612.1 version of WebKit [v2]

2021-07-06 Thread Ambarish Rapte
On Thu, 1 Jul 2021 22:03:48 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - remove unwanted file >> - comment failing test code > > modules/javafx.web/src/test/java/test/javafx/scene/web/H

Re: RFR: 8268849: Update to 612.1 version of WebKit [v2]

2021-07-06 Thread Ambarish Rapte
> Update JavaFX WebKit to GTK WebKit 2.32 (612.1). > There are two separate commits: > 1. > [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc) > : includes only native changes > 2. > [commit](https://github.com/openjdk/jfx/commit/b024c16551be7d929fa1d927d3be

Re: RFR: 8268849: Update to 612.1 version of WebKit

2021-07-01 Thread Kevin Rushforth
On Thu, 1 Jul 2021 08:32:31 GMT, Ambarish Rapte wrote: > Update JavaFX WebKit to GTK WebKit 2.32 (612.1). > There are two separate commits: > 1. > [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc) > : includes only native changes > 2. > [commit](https://g

RFR: 8268849: Update to 612.1 version of WebKit

2021-07-01 Thread Ambarish Rapte
Update JavaFX WebKit to GTK WebKit 2.32 (612.1). There are two separate commits: 1. [commit](https://github.com/openjdk/jfx/commit/ed0baf5f23aed0d8aaa72645c8e03fde56d0f0cc) : includes only native changes 2. [commit](https://github.com/openjdk/jfx/commit/b024c16551be7d929fa1d927d3be8f0fc75a64c3)