On Mon, 25 Oct 2021 23:27:19 GMT, Kevin Rushforth wrote:
> Looks good with a couple suggestions on `setScene`. We might want to also
> file a follow-up javadoc bug so we can get rid of the javadocs for that
> method altogether.
I have filed -
On Mon, 25 Oct 2021 08:30:36 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be generated with the JDK 18 EA build.
>> -
On Fri, 22 Oct 2021 15:00:58 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8271090 - fix review comments
>
> modules/javafx.graphics/src/main/java/javafx/stage/Window.java line 781:
>
>>
On Fri, 22 Oct 2021 15:30:36 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/shape/Box.java line 91:
>>
>>> 89: * Default size of the {@code Box}.
>>> 90: */
>>> 91: public static final double DEFAULT_SIZE = 2;
>>
>> This field was exposed by
On Fri, 22 Oct 2021 14:37:14 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8271090 - fix review comments
>
> modules/javafx.media/src/main/java/javafx/scene/media/Track.java line 85:
>
>> 83:
> This PR fixes javadoc warnings primarily in javafx.graphics module along with
> a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - There are still few remaining warnings in these modules. The root
