Re: RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-22 Thread Kevin Rushforth
On Wed, 22 Sep 2021 13:59:43 GMT, Nir Lisker wrote: > > We added `@SuppressWarnings("removal")` annotations for JDK-8264139, so I'm > > surprised the IDE is still flagging it. > > The warning is on the `import` of the class, which can be suppressed by > adding the annotation to the class decla

Re: RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-22 Thread Nir Lisker
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote: > As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and > `ES2Graphics` are now identical, which should have been the case all along. > The fact that they weren't identical was the source of a bug that was only > discovered d

Re: RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-22 Thread Kevin Rushforth
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote: > As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and > `ES2Graphics` are now identical, which should have been the case all along. > The fact that they weren't identical was the source of a bug that was only > discovered d

Re: RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-21 Thread Nir Lisker
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote: > As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and > `ES2Graphics` are now identical, which should have been the case all along. > The fact that they weren't identical was the source of a bug that was only > discovered d

Re: RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-21 Thread Jose Pereda
On Tue, 21 Sep 2021 12:45:20 GMT, Kevin Rushforth wrote: > As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and > `ES2Graphics` are now identical, which should have been the case all along. > The fact that they weren't identical was the source of a bug that was only > discovered d

RFR: 8273946: Move clearQuad method to BaseShaderGraphics superclass

2021-09-21 Thread Kevin Rushforth
As mentioned in JBS, the `clearQuad` methods in `D3DGraphics` and `ES2Graphics` are now identical, which should have been the case all along. The fact that they weren't identical was the source of a bug that was only discovered during the testing of [JDK-8090547](https://bugs.openjdk.java.net/br