Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]

2022-05-19 Thread Ajit Ghaisas
On Thu, 19 May 2022 14:23:55 GMT, Robert Lichtenberger wrote: >> Separate test class added for TreeTableView case. >> Fix is analogous to JDK-8251480. > > Robert Lichtenberger has updated the pull request incrementally with two > additional commits since the last revision: > > - 8285197: Tabl

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]

2022-05-19 Thread Marius Hanl
On Thu, 19 May 2022 14:23:55 GMT, Robert Lichtenberger wrote: >> Separate test class added for TreeTableView case. >> Fix is analogous to JDK-8251480. > > Robert Lichtenberger has updated the pull request incrementally with two > additional commits since the last revision: > > - 8285197: Tabl

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]

2022-05-19 Thread Robert Lichtenberger
On Thu, 12 May 2022 05:22:38 GMT, Ajit Ghaisas wrote: >> Robert Lichtenberger has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8285197: TableColumnHeader: calc of cell width must respect row styling >> (TreeTableView) >> >>Test

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

2022-05-19 Thread Robert Lichtenberger
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Finally found the time to cleanup the test class... - PR: https://git.openjdk.java.net/jfx/pull/779

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) [v2]

2022-05-19 Thread Robert Lichtenberger
> Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Robert Lichtenberger has updated the pull request incrementally with two additional commits since the last revision: - 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

2022-05-11 Thread Ajit Ghaisas
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. The fix looks good. The newly introduced test file needs some cosmetic cleanups. modules/javafx.controls/src/test/java/test/javafx/scene/control/

Re: RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

2022-05-10 Thread Marius Hanl
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger wrote: > Separate test class added for TreeTableView case. > Fix is analogous to JDK-8251480. Looks good! Verified that the fix works. I can also confirm, that this fix is the same as previously done for `TableView` in PR: https://github.c

RFR: 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView)

2022-04-21 Thread Robert Lichtenberger
Separate test class added for TreeTableView case. Fix is analogous to JDK-8251480. - Commit messages: - 8285197: TableColumnHeader: calc of cell width must respect row styling (TreeTableView) Changes: https://git.openjdk.java.net/jfx/pull/779/files Webrev: https://webrevs.openjdk.